Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix WPT runner cutting off inprogress workers #47626

Closed
wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Apr 19, 2023

Having reviewed the WPT Reports I have noticed the test count varies, see e.g. here for 19.x, 20.x, and experimental, those are the ones where #47283 has landed.

This fixes the runner so that in progress multi-variant tests don't get cut off on the account of having the same filename.

fast-track PRs that do not need to wait for 48 hours to land. because while this bug is in place we're not actually reporting on WPT failures in workers that get terminated.

I've tested this by running wpt report a number of times and getting consistent number of total reported tests.


NB: Having worked with the runner for a bit now I think a bigger refactor is imminent from my side.

@panva panva added test Issues and PRs related to the tests. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 19, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 19, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2023
@nodejs-github-bot
Copy link
Collaborator

@panva
Copy link
Member Author

panva commented Apr 19, 2023

Alternatively, we can revert #47283 and #47376

@panva
Copy link
Member Author

panva commented Apr 19, 2023

Yeah, let's just do that #47627

@panva panva removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 19, 2023
@panva panva closed this Apr 19, 2023
@panva panva deleted the fix-concurrent-wpt branch April 19, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants