Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs, test_runner, timers: Use kResistStopPropagation where applicable #48521

Merged
merged 4 commits into from
Jun 24, 2023
Merged

fs, test_runner, timers: Use kResistStopPropagation where applicable #48521

merged 4 commits into from
Jun 24, 2023

Conversation

atlowChemi
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 22, 2023
benjamingr
benjamingr approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good though for everything that is a resource (like an fs watcher) rather than an action we probably are going to deprecate AbortSignal support in favor of Symbol.dispose.

@atlowChemi atlowChemi marked this pull request as ready for review June 22, 2023 17:15
@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52380/

@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52382/

@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52384/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52391/

@atlowChemi atlowChemi added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 23, 2023
@github-actions github-actions bot mentioned this pull request Jun 24, 2023
Open
25 tasks
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit 78f6952 into nodejs:main Jun 24, 2023
67 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 78f6952

@atlowChemi atlowChemi deleted the use-kResistStopPropagation-where-applicable branch June 24, 2023 17:51
@github-actions github-actions bot mentioned this pull request Jun 25, 2023
Open
25 tasks
@atlowChemi atlowChemi mentioned this pull request Jun 25, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jun 26, 2023
Open
21 tasks
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@atlowChemi @RafaelGSS
fs: use kResistStopPropagation
d367b73 
PR-URL: #48521
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
fs: use kResistStopPropagation
5a21d8f 
PR-URL: nodejs#48521
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
fs: use kResistStopPropagation
5cf1ec1 
PR-URL: nodejs#48521
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@ruyadorno
Copy link
Member

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

@ruyadorno ruyadorno added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Sep 10, 2023
@atlowChemi
Copy link
Member Author

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

Depends on #47775 being backported

@ruyadorno ruyadorno added the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Sep 11, 2023
atlowChemi added a commit to atlowChemi/node that referenced this pull request Sep 12, 2023
@atlowChemi
fs: use kResistStopPropagation
9cde48f 
PR-URL: nodejs#48521
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@atlowChemi atlowChemi mentioned this pull request Sep 12, 2023
Closed
atlowChemi added a commit to atlowChemi/node that referenced this pull request Sep 14, 2023
@atlowChemi
fs: use kResistStopPropagation
c648959 
PR-URL: nodejs#48521
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
atlowChemi added a commit to atlowChemi/node that referenced this pull request Sep 18, 2023
@atlowChemi
fs: use kResistStopPropagation
e2e8ce6 
PR-URL: nodejs#48521
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@atlowChemi atlowChemi added backport-open-v18.x Indicate that the PR has an open backport. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. labels Sep 29, 2023
targos pushed a commit that referenced this pull request Oct 28, 2023
@atlowChemi @targos
fs: use kResistStopPropagation
29dc4b6 
PR-URL: #48521
Backport-PR-URL: #49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targos targos added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Oct 28, 2023
targos pushed a commit that referenced this pull request Oct 28, 2023
@atlowChemi @targos
fs: use kResistStopPropagation
fe41d22 
PR-URL: #48521
Backport-PR-URL: #49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
fs: use kResistStopPropagation
04cf386 
PR-URL: nodejs/node#48521
Backport-PR-URL: nodejs/node#49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
fs: use kResistStopPropagation
9d508d9 
PR-URL: nodejs/node#48521
Backport-PR-URL: nodejs/node#49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@atlowChemi @nodejs-github-bot @ruyadorno @benjamingr @MoLow @targos @debadree25