Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib, net, child_process, streams, dgram, readline, http2: Use addAbortListener where applicable #48550

Closed
wants to merge 8 commits into from
Closed

lib, net, child_process, streams, dgram, readline, http2: Use addAbortListener where applicable #48550

wants to merge 8 commits into from

Conversation

atlowChemi
Copy link
Member

@atlowChemi atlowChemi commented Jun 25, 2023 •
edited
Loading

Refs: #48301, #48521, #48596

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net
  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 25, 2023
@atlowChemi atlowChemi added child_process Issues and PRs related to the child_process subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. net Issues and PRs related to the net subsystem. readline Issues and PRs related to the built-in readline module. stream Issues and PRs related to the stream subsystem. http2 Issues or PRs related to the http2 subsystem. labels Jun 25, 2023
@aduh95

This comment was marked as resolved.

Sign in to view
@atlowChemi

This comment was marked as resolved.

Sign in to view
@atlowChemi atlowChemi force-pushed the use-kResistStopPropagation-where-applicable-2 branch from 90922af to c0dbb4b Compare June 26, 2023 03:43
@atlowChemi

This comment was marked as resolved.

Sign in to view
@atlowChemi

This comment was marked as off-topic.

Sign in to view
@aduh95

This comment was marked as off-topic.

Sign in to view
ronag
ronag reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjamingr This is... sad... I'm starting to feel that adding support for abort signals might not have been the optimal decision.

@aduh95 aduh95 added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jun 26, 2023
@benjamingr
Copy link
Member

@ronag

This is... sad... I'm starting to feel that adding support for abort signals might not have been the optimal decision.

It was not, I (and others) totally missed this was unsafe and didn't understand how hard leaks would be. We also failed to appreciate how much the web would deviate in priorities (they're not really interested in fixing this, they like signal.reason which explodes our API surface etc). These may be fixable in the spec but I doubt there is implementor interest.

We should provide a utility for memory safe registration that is guaranteed to trigger and deprecate AbortSignal support for everything that is a resource (like http.Server, streams etc) in favor of Symbol.asyncDispose and Symbol.dispose now that they exist.

Note in an ideal where everything that needs to support a signal does - users won't run into this since they just pass signals down.

@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52483/

@atlowChemi atlowChemi added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52492/

@github-actions github-actions bot mentioned this pull request Jun 27, 2023
Open
24 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52509/

@github-actions github-actions bot mentioned this pull request Jun 28, 2023
Open
36 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
readline: use addAbortListener
961d209 
PR-URL: nodejs#48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
stream: use addAbortListener
9c8baa3 
PR-URL: nodejs#48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
dgram: use addAbortListener
2f73350 
PR-URL: nodejs#48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
net: use addAbortListener
177ec8a 
PR-URL: nodejs#48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
child_process: use addAbortListener
d73d83c 
PR-URL: nodejs#48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
lib: use addAbortListener
8a02767 
PR-URL: nodejs#48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@ruyadorno
Copy link
Member

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

@ruyadorno ruyadorno added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Sep 11, 2023
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@atlowChemi @ruyadorno
http2: use addAbortListener
aaa8857 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@atlowChemi @ruyadorno
readline: use addAbortListener
d28b1ee 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@atlowChemi @ruyadorno
stream: use addAbortListener
051d5ae 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@atlowChemi @ruyadorno
dgram: use addAbortListener
5780364 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@atlowChemi @ruyadorno
child_process: use addAbortListener
f6bad9d 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@atlowChemi @ruyadorno
lib: use addAbortListener
8f7f0d9 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 11, 2023
Merged
@atlowChemi
Copy link
Member Author

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

@ruyadorno is this still relevant? seems like the commits have been added to the proposal?

ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@atlowChemi @ruyadorno
http2: use addAbortListener
627bc92 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@atlowChemi @ruyadorno
readline: use addAbortListener
b5c7634 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@atlowChemi @ruyadorno
stream: use addAbortListener
c44413d 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@atlowChemi @ruyadorno
dgram: use addAbortListener
cfeee51 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@atlowChemi @ruyadorno
child_process: use addAbortListener
24eeae3 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@atlowChemi @ruyadorno
lib: use addAbortListener
33c9cea 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@atlowChemi @ruyadorno
http2: use addAbortListener
be88f7c 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@atlowChemi @ruyadorno
readline: use addAbortListener
cb51ef2 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@atlowChemi @ruyadorno
stream: use addAbortListener
3dd82b1 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@atlowChemi @ruyadorno
dgram: use addAbortListener
f3c4300 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@atlowChemi @ruyadorno
child_process: use addAbortListener
b5df084 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@atlowChemi @ruyadorno
lib: use addAbortListener
f74c2fc 
PR-URL: #48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
H4ad pushed a commit to H4ad/node that referenced this pull request Sep 17, 2023
@atlowChemi @H4ad
http2: use addAbortListener
e73c404 
PR-URL: nodejs#48550
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@simatec simatec mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag left review comments

@MoLow MoLow MoLow left review comments

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. child_process Issues and PRs related to the child_process subsystem. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dgram Issues and PRs related to the dgram subsystem / UDP. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. readline Issues and PRs related to the built-in readline module. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@atlowChemi @nodejs-github-bot @aduh95 @benjamingr @mcollina @MoLow @ruyadorno @ronag