stream: support dispose in writable #48547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Add support to Symbol.asyncDispose in writable streams. Additionally add a test for writable, transform and duplex streams who inherit from readable/writable to avoid breakage.
benjamingr
force-pushed
the
add-abortsignal-writable
branch
from
f38134b
to
63aad0a
Compare
benjamingr
added
stream
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
benjamingr
commented
Jun 25, 2023
ronag
reviewed
Jun 25, 2023
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Robert Nagy <ronagy@icloud.com>
github-actions
bot
removed
the
request-ci
MoLow
reviewed
Jun 25, 2023
| }); | ||
| let count = 0; | ||
| duplex.on('error', common.mustCall((e) => { | ||
| assert.strictEqual(count++, 0); // Ensure not called twice |
There was a problem hiding this comment.
common.mustCall accepts a count argument: common.mustCall(fn, times)
MoLow
approved these changes
Jun 25, 2023
This was referenced Jun 26, 2023
ronag
reviewed
Jun 27, 2023
This was referenced Jun 28, 2023
Co-authored-by: Robert Nagy <ronagy@icloud.com>
github-actions
bot
removed
the
request-ci
This was referenced Jun 30, 2023
This was referenced Jul 7, 2023
|
This needs a rebase. |
ronag
approved these changes
May 11, 2024
atlowChemi
reviewed
May 12, 2024
| error = this.writableFinished ? null : new AbortError(); | ||
| this.destroy(error); | ||
| } | ||
| return new Promise((resolve, reject) => eos(this, (err) => (err && err.name !== 'AbortError ? reject(err) : resolve(null)))); |
There was a problem hiding this comment.
Suggested change
| return new Promise((resolve, reject) => eos(this, (err) => (err && err.name !== 'AbortError ? reject(err) : resolve(null)))); | |
| return new Promise((resolve, reject) => eos(this, (err) => (err && err.name !== 'AbortError' ? reject(err) : resolve(null)))); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to
Symbol.asyncDisposein writable streams. Additionally add a test for writable, transform and duplex streams (that inherit from readable/writable) to avoid breakage.cc @nodejs/streams @MoLow @atlowChemi