src: modernize use-equals-default #48735

CGQAQ · 2023-07-11T05:31:03Z

https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html

nodejs-github-bot · 2023-07-11T05:31:08Z

Review requested:

@nodejs/startup

aduh95 · 2023-07-15T17:47:53Z

@nodejs/cpp-reviewers

src/api/environment.cc

nodejs-github-bot · 2023-07-16T13:39:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52789/

nodejs-github-bot · 2023-07-17T14:51:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52810/

nodejs-github-bot · 2023-08-10T23:07:22Z

Commit Queue failed

- Loading data for nodejs/node/pull/48735 ✔ Done loading data for nodejs/node/pull/48735 ----------------------------------- PR info ------------------------------------ Title src: modernize use-equals-default (#48735) Author Jason (@CGQAQ) Branch CGQAQ:modernize-equals-default -> nodejs:main Labels c++, author ready, needs-ci Commits 4 - src: modernize use-equals-default - src: more modernize use-equals-default - src: move `= default` to header file - src: fix build Committers 1 - CGQAQ PR-URL: https://github.com/nodejs/node/pull/48735 Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48735 Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 11 Jul 2023 05:31:03 GMT ✔ Approvals: 1 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/48735#pullrequestreview-1531740351 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-07-17T14:51:49Z: https://ci.nodejs.org/job/node-test-pull-request/52810/ - Querying data for job/node-test-pull-request/52810/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD f1b3ade948..54e4f1f5e6 main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - bb531e9b0e src: fix callback_queue.h missing header - 54e4f1f5e6 src: fix callback_queue.h missing header -------------------------------------------------------------------------------- HEAD is now at 54e4f1f5e6 src: fix callback_queue.h missing header ✔ Reset to origin/main - Downloading patch for 48735 From https://github.com/nodejs/node * branch refs/pull/48735/merge -> FETCH_HEAD ✔ Fetched commits as 54e4f1f5e6bf..d9ce897e1d2b -------------------------------------------------------------------------------- Auto-merging src/cleanup_queue.h Auto-merging src/node.cc [main 3f09ef87d6] src: modernize use-equals-default Author: CGQAQ Date: Tue Jul 11 05:29:31 2023 +0000 3 files changed, 4 insertions(+), 4 deletions(-) Auto-merging src/js_native_api_v8.h Auto-merging src/json_parser.h [main f8c18aaad1] src: more modernize use-equals-default Author: CGQAQ Date: Tue Jul 11 07:25:03 2023 +0000 6 files changed, 7 insertions(+), 9 deletions(-) Auto-merging src/node.cc [main 6811412d05] src: move `= default` to header file Author: CGQAQ Date: Tue Jul 11 07:29:57 2023 +0000 6 files changed, 4 insertions(+), 11 deletions(-) [main c2a9d17111] src: fix build Author: CGQAQ Date: Wed Jul 12 07:24:52 2023 +0000 2 files changed, 3 insertions(+), 1 deletion(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: modernize use-equals-default

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

[detached HEAD ae1a25b7ec] src: modernize use-equals-default
Author: CGQAQ m.jason.liu@outlook.com
Date: Tue Jul 11 05:29:31 2023 +0000
3 files changed, 4 insertions(+), 4 deletions(-)
Rebasing (3/8)
Rebasing (4/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: more modernize use-equals-default

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

[detached HEAD c5101bc8e2] src: more modernize use-equals-default
Author: CGQAQ m.jason.liu@outlook.com
Date: Tue Jul 11 07:25:03 2023 +0000
6 files changed, 7 insertions(+), 9 deletions(-)
Rebasing (5/8)
Rebasing (6/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: move = default to header file

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

[detached HEAD 15e28fece8] src: move = default to header file
Author: CGQAQ m.jason.liu@outlook.com
Date: Tue Jul 11 07:29:57 2023 +0000
6 files changed, 4 insertions(+), 11 deletions(-)
Rebasing (7/8)
Rebasing (8/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: fix build

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

[detached HEAD 7b65b846ba] src: fix build
Author: CGQAQ m.jason.liu@outlook.com
Date: Wed Jul 12 07:24:52 2023 +0000
2 files changed, 3 insertions(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5826964021

nodejs-github-bot · 2023-08-11T15:32:14Z

Commit Queue failed

- Loading data for nodejs/node/pull/48735 ✔ Done loading data for nodejs/node/pull/48735 ----------------------------------- PR info ------------------------------------ Title src: modernize use-equals-default (#48735) Author Jason (@CGQAQ) Branch CGQAQ:modernize-equals-default -> nodejs:main Labels c++, author ready, needs-ci Commits 4 - src: modernize use-equals-default - src: more modernize use-equals-default - src: move `= default` to header file - src: fix build Committers 1 - CGQAQ PR-URL: https://github.com/nodejs/node/pull/48735 Reviewed-By: Rafael Gonzaga Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48735 Reviewed-By: Rafael Gonzaga Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 11 Jul 2023 05:31:03 GMT ✔ Approvals: 2 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/48735#pullrequestreview-1531740351 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/48735#pullrequestreview-1572852238 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-08-10T23:07:22Z: https://ci.nodejs.org/job/node-test-pull-request/52810/ - Querying data for job/node-test-pull-request/52810/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD 9497665d19..7ffa5d7f0d main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - c8294abaef src: avoid string copy in BuiltinLoader::GetBuiltinIds - 7ffa5d7f0d src: avoid string copy in BuiltinLoader::GetBuiltinIds -------------------------------------------------------------------------------- HEAD is now at 7ffa5d7f0d src: avoid string copy in BuiltinLoader::GetBuiltinIds ✔ Reset to origin/main - Downloading patch for 48735 From https://github.com/nodejs/node * branch refs/pull/48735/merge -> FETCH_HEAD ✔ Fetched commits as 7ffa5d7f0d6e..d9ce897e1d2b -------------------------------------------------------------------------------- Auto-merging src/cleanup_queue.h Auto-merging src/node.cc [main f509bef6b0] src: modernize use-equals-default Author: CGQAQ Date: Tue Jul 11 05:29:31 2023 +0000 3 files changed, 4 insertions(+), 4 deletions(-) Auto-merging src/js_native_api_v8.h Auto-merging src/json_parser.h [main d02955f77d] src: more modernize use-equals-default Author: CGQAQ Date: Tue Jul 11 07:25:03 2023 +0000 6 files changed, 7 insertions(+), 9 deletions(-) Auto-merging src/node.cc Auto-merging src/node.h [main dac4e554c3] src: move `= default` to header file Author: CGQAQ Date: Tue Jul 11 07:29:57 2023 +0000 6 files changed, 4 insertions(+), 11 deletions(-) [main 59d3607ea3] src: fix build Author: CGQAQ Date: Wed Jul 12 07:24:52 2023 +0000 2 files changed, 3 insertions(+), 1 deletion(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: modernize use-equals-default

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

[detached HEAD d45f4acd5f] src: modernize use-equals-default
Author: CGQAQ m.jason.liu@outlook.com
Date: Tue Jul 11 05:29:31 2023 +0000
3 files changed, 4 insertions(+), 4 deletions(-)
Rebasing (3/8)
Rebasing (4/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: more modernize use-equals-default

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

[detached HEAD 77ff38e3c2] src: more modernize use-equals-default
Author: CGQAQ m.jason.liu@outlook.com
Date: Tue Jul 11 07:25:03 2023 +0000
6 files changed, 7 insertions(+), 9 deletions(-)
Rebasing (5/8)
Rebasing (6/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: move = default to header file

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

[detached HEAD b17ede622e] src: move = default to header file
Author: CGQAQ m.jason.liu@outlook.com
Date: Tue Jul 11 07:29:57 2023 +0000
6 files changed, 4 insertions(+), 11 deletions(-)
Rebasing (7/8)
Rebasing (8/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
src: fix build

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

[detached HEAD 4da8d2c214] src: fix build
Author: CGQAQ m.jason.liu@outlook.com
Date: Wed Jul 12 07:24:52 2023 +0000
2 files changed, 3 insertions(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5834338909

nodejs-github-bot · 2023-08-11T17:58:07Z

Landed in f426cc0

PR-URL: nodejs#48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: nodejs#48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

src: modernize use-equals-default

5f94a84

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 11, 2023

CGQAQ added 3 commits July 11, 2023 07:25

src: more modernize use-equals-default

b2a9d7f

src: move = default to header file

4cf5d59

src: fix build

d9ce897

RafaelGSS reviewed Jul 15, 2023

View reviewed changes

src/api/environment.cc Show resolved Hide resolved

RafaelGSS approved these changes Jul 16, 2023

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 16, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 16, 2023

github-actions bot mentioned this pull request Jul 17, 2023

CI Reliability 2023-07-17 nodejs/reliability#615

Open

25 tasks

This was referenced Jul 18, 2023

CI Reliability 2023-07-18 nodejs/reliability#616

Open

CI Reliability 2023-07-19 nodejs/reliability#617

Open

CI Reliability 2023-07-20 nodejs/reliability#618

Open

CI Reliability 2023-07-21 nodejs/reliability#619

Open

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2023

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 10, 2023

anonrig approved these changes Aug 10, 2023

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 11, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 11, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 11, 2023

nodejs-github-bot merged commit f426cc0 into nodejs:main Aug 11, 2023
73 checks passed

martenrichter pushed a commit to martenrichter/node that referenced this pull request Aug 13, 2023

src: modernize use-equals-default

a84c16b

PR-URL: nodejs#48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023

src: modernize use-equals-default

d03398d

PR-URL: nodejs#48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023

src: modernize use-equals-default

710fb43

PR-URL: nodejs#48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023

src: modernize use-equals-default

9c217e8

PR-URL: #48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

UlisesGascon mentioned this pull request Aug 15, 2023

v20.6.0 proposal #49185

Merged

RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023

src: modernize use-equals-default

ee49c04

PR-URL: nodejs#48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023

src: modernize use-equals-default

2f70707

PR-URL: nodejs#48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023

src: modernize use-equals-default

45f8a39

PR-URL: #48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023

src: modernize use-equals-default

f126b9e

PR-URL: #48735 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

CGQAQ deleted the modernize-equals-default branch January 16, 2024 02:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: modernize use-equals-default #48735

src: modernize use-equals-default #48735

CGQAQ commented Jul 11, 2023

nodejs-github-bot commented Jul 11, 2023

aduh95 commented Jul 15, 2023

nodejs-github-bot commented Jul 16, 2023

nodejs-github-bot commented Jul 17, 2023

nodejs-github-bot commented Aug 10, 2023

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Aug 11, 2023

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Aug 11, 2023

src: modernize use-equals-default #48735

src: modernize use-equals-default #48735

Conversation

CGQAQ commented Jul 11, 2023

nodejs-github-bot commented Jul 11, 2023

aduh95 commented Jul 15, 2023

nodejs-github-bot commented Jul 16, 2023

nodejs-github-bot commented Jul 17, 2023

nodejs-github-bot commented Aug 10, 2023

PR-URL: #48735 Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

PR-URL: #48735 Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

PR-URL: #48735 Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

PR-URL: #48735 Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Aug 11, 2023

PR-URL: #48735 Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #48735 Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #48735 Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #48735 Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Aug 11, 2023

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #48735
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com