Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use same name in the doc as in the code #49216

Merged
merged 1 commit into from Aug 19, 2023

Conversation

illusi0n7
Copy link
Contributor

Since the specification and code explicitly use the name init, I think it would be clearer to use init in error message and documentation as well.

Refs: https://streams.spec.whatwg.org/#bytelengthqueuingstrategy

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Aug 17, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2023
@nodejs-github-bot
Copy link
Collaborator

@deokjinkim deokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit cb4a6fa into nodejs:main Aug 19, 2023
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in cb4a6fa

@illusi0n7 illusi0n7 deleted the dev/rename branch August 23, 2023 04:19
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
Refs: https://streams.spec.whatwg.org/#bytelengthqueuingstrategy
PR-URL: #49216
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
targos pushed a commit that referenced this pull request Nov 27, 2023
Refs: https://streams.spec.whatwg.org/#bytelengthqueuingstrategy
PR-URL: #49216
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Refs: https://streams.spec.whatwg.org/#bytelengthqueuingstrategy
PR-URL: nodejs/node#49216
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Refs: https://streams.spec.whatwg.org/#bytelengthqueuingstrategy
PR-URL: nodejs/node#49216
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. web streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants