Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] backport multiple test runner related prs #49225

Closed
wants to merge 8 commits into from
Closed

[v20.x backport] backport multiple test runner related prs #49225

wants to merge 8 commits into from

Commits on Sep 4, 2023

  1. test: reorder test files fixtures for better understanding 

    PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    @rluvaton
    rluvaton committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    2e0df36 View commit details
    Browse the repository at this point in the history

  2. test_runner: fix global before not called when no global test exists 

    PR-URL: nodejs#48877
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    @rluvaton
    rluvaton committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    b84b2bf View commit details
    Browse the repository at this point in the history

  3. test_runner: cleanup test timeout abort listener 

    fix nodejs#48475

PR-URL: nodejs#48915
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    @rluvaton
    rluvaton committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    b91c906 View commit details
    Browse the repository at this point in the history

  4. test_runner: fix timeout in *Each hook failing further tests 

    PR-URL: nodejs#48925
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    @rluvaton
    rluvaton committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    684137b View commit details
    Browse the repository at this point in the history

  5. test_runner: fix global after not failing the tests 

    PR-URL: nodejs#48913
Fixes: nodejs#48867
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    @rluvaton
    rluvaton committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    19771a8 View commit details
    Browse the repository at this point in the history

  6. test: remove --no-warnings flag in test_runner fixtures 

    no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    @rluvaton
    rluvaton committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    dbc3124 View commit details
    Browse the repository at this point in the history

  7. test_runner: expose location of tests 

    This commit adds each test's line and column number to the reporter
output. This will aid in debugging test suite failures when error
stacks are not helpful, test suites are large, or tests have the
same name. This data is also exposed on the spec reporter.

This commit also replaces the filename that was previously being
reported, with the filename where the test actually exists. These
are normally correct, but could be wrong if tests were run from
a file other than the user's entrypoint.

PR-URL: nodejs#48975
Fixes: nodejs#48457
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    @cjihrig @rluvaton
    cjihrig authored and rluvaton committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    7c011b6 View commit details
    Browse the repository at this point in the history

  8. test_runner: reland run global after() hook earlier 

    This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @cjihrig @rluvaton
    cjihrig authored and rluvaton committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    2ad1bbc View commit details
    Browse the repository at this point in the history