Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sea: generate code cache with deserialized isolate #49226

Closed
wants to merge 2 commits into from
Closed

sea: generate code cache with deserialized isolate #49226

wants to merge 2 commits into from
+82 −10

Commits on Aug 18, 2023

  1. src: support snapshot deserialization in RAIIIsolate

    @joyeecheung
    joyeecheung committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    1cf140a View commit details
    Browse the repository at this point in the history

  2. sea: generate code cache with deserialized isolate 

    V8 now requires code cache to be compiled from an isolate with the
same RO space layout as the one that's going to deserialize the
cache, so for a binary built with snapshot, we need to compile
the code cache using a deserialized isolate.

Drive-by: ignore "useCodeCache" when "useSnapshot" is true because
the compilation would've been done during build time anyway in
that case, and print a warning for it.
    @joyeecheung
    joyeecheung committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    661edfe View commit details
    Browse the repository at this point in the history