Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused function GetName() in node_perf #49244

Merged
merged 2 commits into from Aug 21, 2023
Merged

src: remove unused function GetName() in node_perf #49244

merged 2 commits into from Aug 21, 2023

Conversation

pluris
Copy link
Contributor

@pluris pluris commented Aug 19, 2023 •
edited

I looked through the code, but couldn't find where GetName() is used.
Both test and build passed, I think it can be deleted.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 19, 2023
aduh95
aduh95 reviewed Aug 19, 2023
View reviewed changes
src/node_perf.cc Outdated Show resolved Hide resolved
@pluris pluris requested a review from aduh95 August 19, 2023 16:58
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53450/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53453/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 20, 2023
@deokjinkim deokjinkim added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 20, 2023
@github-actions github-actions bot mentioned this pull request Aug 21, 2023
Open
35 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit a16b610 into nodejs:main Aug 21, 2023
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a16b610

This was referenced Aug 22, 2023
Open
Open
Open
@pluris pluris deleted the remove/unused_function branch August 30, 2023 16:12
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@pluris @UlisesGascon
src: remove unused function GetName() in node_perf
dc09286 
PR-URL: #49244
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@pluris @targos
src: remove unused function GetName() in node_perf
066d9d4 
PR-URL: #49244
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: remove unused function GetName() in node_perf
df883b8 
PR-URL: nodejs/node#49244
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: remove unused function GetName() in node_perf
a28f870 
PR-URL: nodejs/node#49244
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deokjinkim deokjinkim deokjinkim approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pluris @nodejs-github-bot @deokjinkim @aduh95