doc: rename possibly confusing variable #49536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A "selector" usually refers to a CSS selector, when here it refers to a checkbox.
|
Review requested:
|
ovflowd
approved these changes
Sep 7, 2023
|
Fast-track has been requested by @ovflowd. Please 👍 to approve. |
bnb
approved these changes
Sep 7, 2023
atlowChemi
approved these changes
Sep 7, 2023
aduh95
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49536 ✔ Done loading data for nodejs/node/pull/49536 ----------------------------------- PR info ------------------------------------ Title doc: rename possibly confusing variable (#49536) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:flavor-selector-toggle -> nodejs:main Labels doc, fast-track, author ready Commits 2 - doc: rename possibly confusing variable - fixup! doc: rename possibly confusing variable Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/49536 Reviewed-By: Claudio Wunder Reviewed-By: Tierney Cyren Reviewed-By: Chemi Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49536 Reviewed-By: Claudio Wunder Reviewed-By: Tierney Cyren Reviewed-By: Chemi Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 07 Sep 2023 14:49:39 GMT ✔ Approvals: 3 ✔ - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/49536#pullrequestreview-1615635164 ✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/49536#pullrequestreview-1615729819 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49536#pullrequestreview-1617314184 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6122057730 |
|
Landed in 8103a64 |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
A "selector" usually refers to a CSS selector, when here it refers to a checkbox. PR-URL: #49536 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
A "selector" usually refers to a CSS selector, when here it refers to a checkbox. PR-URL: nodejs#49536 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A "selector" usually refers to a CSS selector, when here it refers to a checkbox.