Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: use determineSpecificType in more error messages #49580

Merged
merged 1 commit into from Sep 11, 2023
Merged

errors: use determineSpecificType in more error messages #49580

merged 1 commit into from Sep 11, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 9, 2023

Before it would have say something like Expected a … to be returned for the "…" from the function but got an instance of String., and with this PR it would say the more useful and more correct Expected a … to be returned for the "…" from the function but got type string ('the input string').

Fixes: #49576

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Sep 9, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53861/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit d3e0331 into nodejs:main Sep 11, 2023
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d3e0331

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@aduh95 @ruyadorno
errors: use determineSpecificType in more error messages
6377f1b 
PR-URL: #49580
Fixes: #49576
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@aduh95 @alexfernandez
errors: use determineSpecificType in more error messages
33f7abd 
PR-URL: nodejs#49580
Fixes: nodejs#49576
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loaders: super confusing "expected string but got instance of string"
4 participants
@aduh95 @nodejs-github-bot @anonrig @KhafraDev