Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove @anonrig from performance initiative #49641

Closed
wants to merge 1 commit into from
Closed

doc: remove @anonrig from performance initiative #49641

wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 13, 2023

I'll continue working on performance but I don't feel comfortable being the champion of the performance strategic initiative anymore.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 13, 2023
bnb
bnb approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

MoLow
MoLow approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your work is highly appreciated, sorry to see you step back

@Uzlopak

This comment has been minimized.

Sign in to view
@Jarred-Sumner
Copy link

i'm sorry

@joshmanders
Copy link

I wish the community wasn't so toxic. Thank you for all your hard work. <3

@JoaoOtavioS
Copy link

Thank you for everything you did.

[in Portuguese] Obrigado por tudo que fez e continua fazendo nesta comunidade, acredito que comentários ruins sempre existirão em todo lugar, raramente vejo algum brasileiro além do Erick Wendel tão empolgado com suas contribuições, portanto acho importante registrar aqui um pequeno agradecimento. Obrigado novamente.

@trivikr
Copy link
Member

trivikr commented Sep 14, 2023

Thank you, @anonrig, for your valuable contributions to improving Node.js performance ❤️

I hope you come back stronger after a brief break, to champion the performance strategic initiative again!

@fox1t
Copy link
Contributor

fox1t commented Sep 14, 2023

This makes me so sad. The worst part of the Internet fucked up the good part of it again. Thanks for everything you did, and you will do from now on.

mcollina
mcollina approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@manekinekko
Copy link
Contributor

Thank you for your valuable contributions @anonrig ❤️

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 14, 2023
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2023
@brunogrcsada
Copy link

Thank you @anonrig for all of the hours you have put in, and like everyone here I'm so sorry about all of the toxicity at the moment!

@bdbch
Copy link

bdbch commented Sep 14, 2023

While I tried out many NPM alternatives I always came back to NPM. Thanks for your work – I can't imagine the pressure / feeling you have. I always feel like I'm a worse developer than others but being consumed by a hypetrain must feel super bad. You have my sympathies.

People really need to chill and realize that there is a human behind every line of code (most of the time).

@mertcanaltin
Copy link
Member

Thank you very much for everything ❤️

@Cadienvan
Copy link

I can't tell you how much I appreciate you and the job you do daily for the Node project.

@nigelnindodev
Copy link

Damn. Keep on with the good work in whatever you choose to focus on next.

tony-go
tony-go approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@tony-go tony-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sad to see this. Really appreciate your energy, @anonrig; thanks to this energy, I learned to push back my fear about touching the codebase.

Keep that please 🙏🏼

Love you bro ❤️

ovflowd
ovflowd approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sort of Pull Request that approving just feels wrong.

I'm so sorry for everything you went through, and I hope you're able to take some quality personal time.

Qard
Qard approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I greatly appreciate all the amazing work you've done for Node.js performance! We need more people that care so much about improving the performance of Node.js. Take care, Yagiz! ❤️

@rluvaton
Copy link
Member

As soon as I saw that I said noooooooo, wish you the best!

sheplu
sheplu approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels wrong to LGTM so LBTM !

You did and are doing amazing work! Thanks for all your contributions

cozzbie
cozzbie reviewed Sep 14, 2023
View reviewed changes
Copy link

@cozzbie cozzbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@nodejs nodejs deleted a comment from mikelerch Sep 14, 2023
@nodejs nodejs locked as too heated and limited conversation to collaborators Sep 14, 2023
@benjamingr benjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 14, 2023
@nodejs nodejs unlocked this conversation Sep 14, 2023
@benjamingr benjamingr added fast-track PRs that do not need to wait for 48 hours to land. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Sep 14, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 14, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49641
✔  Done loading data for nodejs/node/pull/49641
----------------------------------- PR info ------------------------------------
Title      doc: remove `@anonrig` from performance initiative (#49641)
Author     Yagiz Nizipli  (@anonrig)
Branch     anonrig:perf-strategic-initiative -> nodejs:main
Labels     doc, fast-track, author ready
Commits    1
 - doc: remove `@anonrig` from performance initiative
Committers 1
 - Yagiz Nizipli 
PR-URL: https://github.com/nodejs/node/pull/49641
Reviewed-By: Tierney Cyren 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Darshan Sen 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Marco Ippolito 
Reviewed-By: Claudio Wunder 
Reviewed-By: Stephen Belanger 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49641
Reviewed-By: Tierney Cyren 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Darshan Sen 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Marco Ippolito 
Reviewed-By: Claudio Wunder 
Reviewed-By: Stephen Belanger 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 13 Sep 2023 20:44:31 GMT
   ✔  Approvals: 11
   ✔  - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625430602
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625509384
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625535709
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1625548463
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626092103
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626250563
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626261122
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/49641#pullrequestreview-1626399738
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/49641#pullrequestreview-1627144546
   ✔  - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/49641#pullrequestreview-1627158595
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49641#pullrequestreview-1627214544
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6189910533

@nodejs nodejs locked as too heated and limited conversation to collaborators Sep 14, 2023
@Trott
Copy link
Member

Trott commented Sep 14, 2023

Landed in ba28cd8

@Trott Trott closed this Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cozzbie cozzbie cozzbie left review comments

@mcollina mcollina mcollina approved these changes

@Qard Qard Qard approved these changes

@jasnell jasnell jasnell approved these changes

@bnb bnb bnb approved these changes

@sheplu sheplu sheplu approved these changes

@benjamingr benjamingr benjamingr approved these changes

@tniessen tniessen tniessen approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@MoLow MoLow MoLow approved these changes

@ovflowd ovflowd ovflowd approved these changes

@aduh95 aduh95 aduh95 approved these changes

@tony-go tony-go tony-go approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet