Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "test: mark test-http-regr-gh-2928 as flaky" #49708

Merged
merged 1 commit into from Sep 20, 2023

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Sep 18, 2023

This reverts commit 48fcb20.

Refs: 18e00a577d74

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 18, 2023
@lpinca lpinca marked this pull request as ready for review September 18, 2023 18:22
@joyeecheung
Copy link
Member

Queued a stress test for this on win2016-vs2017, win2012r2-vs2015 (not sure if the job works on these two though) and FreeBSD https://ci.nodejs.org/job/node-stress-single-test/449

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2023
@nodejs-github-bot nodejs-github-bot merged commit 480ab8c into nodejs:main Sep 20, 2023
84 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 480ab8c

@lpinca lpinca deleted the revert/pr-49565 branch September 20, 2023 18:42
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
This reverts commit 48fcb20.

Refs: 18e00a577d74
PR-URL: #49708
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Sep 28, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
This reverts commit 48fcb20.

Refs: nodejs@18e00a577d74
PR-URL: nodejs#49708
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
This reverts commit 48fcb20.

Refs: 18e00a577d74
PR-URL: #49708
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This reverts commit 48fcb205e4577fd0096f6b772ca250c6dbf759e3.

Refs: nodejs/node@18e00a577d74
PR-URL: nodejs/node#49708
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
This reverts commit 48fcb205e4577fd0096f6b772ca250c6dbf759e3.

Refs: nodejs/node@18e00a577d74
PR-URL: nodejs/node#49708
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants