test: replace forEach() in test-net-perf_hooks with for of #49831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Sep 23, 2023
lpinca
added
the
code-and-learn
narcisacodreanu
force-pushed
the
replace-foreach-in-tests
branch
from
518342d
to
1de9402
Compare
narcisacodreanu
force-pushed
the
replace-foreach-in-tests
branch
from
1de9402
to
c3cdaa7
Compare
trivikr
approved these changes
Sep 25, 2023
|
hi @lpinca and @trivikr, thanks for approving this PR! Would you be able to point me to what the next steps would be to move it forward? This is my first contribution to node and I'm not sure how to go about landing the PR and merging it (https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-10-landing) |
joesepi
approved these changes
Sep 25, 2023
|
Hi @tniessen let me know if you have any advice on the next steps to move the PR forward. This was part of the Open Source Day event for GHC. Much appreciated, thanks! |
|
@narcisacodreanu Apologies for the delay on our end. Once CI passes (which might take a while), this is good to go! |
tniessen
approved these changes
Oct 5, 2023
tniessen
added
the
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
10 tasks
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2fe511b |
|
Thank you for the contribution @narcisacodreanu! |
This was referenced Oct 7, 2023
Yaay, thank you for your help @tniessen!! |
24 tasks
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49831 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Joe Sepi <sepi@joesepi.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49831 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Joe Sepi <sepi@joesepi.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
PR-URL: nodejs#49831 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Joe Sepi <sepi@joesepi.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the use of
forEach()intest-net-perf_hooks.jsby replacing it withfor ... of(Part of Open Source Day at GHC 2023)