Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: move @danielleadams to tsc non-voting member #50142

Merged
merged 1 commit into from Oct 11, 2023
Merged

doc: move @danielleadams to tsc non-voting member #50142

merged 1 commit into from Oct 11, 2023

Conversation

danielleadams
Copy link
Member

My availability has not allowed me to give the amount of time that I would like to Node these past few months, so I'm going to step down from the TSC. I am hoping that I can figure out a way to get back into the project in the future.

Thank you all for the hard work and learning experiences.
馃憢馃徏

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 11, 2023
@danielleadams danielleadams changed the title doc: remove @danielleadams from tsc doc: move @danielleadams to tsc non-voting member Oct 11, 2023
@mhdawson
Copy link
Member

Thanks for all of your work and contributions, sorry to see you go. Hopefully we'll cross paths again at some point.

mhdawson
mhdawson approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Danielle, working with you was a huge pleasure!

tniessen
tniessen approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your amazing work Danielle :)

RaisinTen
RaisinTen approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to hear about this Danielle 馃槩
Hope to see you again in the project 鉂わ笍

anonrig
anonrig approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for everything Danielle

benjamingr
benjamingr approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and hope to continue seeing you around in other roles.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 11, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 馃憤 to approve.

@Trott
Copy link
Member

Trott commented Oct 11, 2023

Thank you for all you've done and for always being wonderful to collaborate with. Best of luck with everything and I hope our paths cross again before too long.

RafaelGSS
RafaelGSS approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Danielle!

ruyadorno
ruyadorno approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for everything Danielle!

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 11, 2023
@aduh95 aduh95 merged commit 91d2132 into nodejs:main Oct 11, 2023
21 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Oct 11, 2023 •
edited

Landed in 91d2132, thanks again for your amazing work, and hopefully until next time :)

aduh95 added a commit to nodejs/create-node-meeting-artifacts that referenced this pull request Oct 11, 2023
@aduh95
doc: move danielleadams to TSC non-voting member
4730976 
Refs: nodejs/node#50142
aduh95 added a commit to nodejs/email that referenced this pull request Oct 11, 2023
@aduh95
doc: move danielleadams to TSC non-voting member
453e40d 
Refs: nodejs/node#50142
@aduh95 aduh95 mentioned this pull request Oct 11, 2023
Merged
richardlau pushed a commit to nodejs/email that referenced this pull request Oct 11, 2023
@aduh95
doc: move danielleadams to TSC non-voting member (#229)
9731b46 
Refs: nodejs/node#50142
@RafaelGSS RafaelGSS mentioned this pull request Oct 15, 2023
Merged
@danielleadams danielleadams deleted the remove-danielle-from-tsc branch October 16, 2023 00:43
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@danielleadams @alexfernandez
doc: move danielleadams to TSC non-voting member
e42f8e4 
PR-URL: nodejs#50142
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nie脽en <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@danielleadams @targos
doc: move danielleadams to TSC non-voting member
7b97c44 
PR-URL: #50142
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nie脽en <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@danielleadams @debadree25
doc: move danielleadams to TSC non-voting member
d8ddf86 
PR-URL: nodejs#50142
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nie脽en <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@mhdawson mhdawson mhdawson approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet