Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: revert IS_RELEASE to 0 #50378

Closed
wants to merge 1 commit into from
Closed

src: revert IS_RELEASE to 0 #50378

wants to merge 1 commit into from

Conversation

rluvaton
Copy link
Member

the test-release-changelog.js test failed and I believe we should revert the is release back to 0

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 24, 2023
@rluvaton rluvaton requested a review from targos October 24, 2023 22:34
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@richardlau
Copy link
Member

Being fixed in #50375.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55208/

@richardlau richardlau added needs-ci PRs that need a full CI run. and removed needs-ci PRs that need a full CI run. labels Oct 24, 2023
@rluvaton
Copy link
Member Author

Thanks

@rluvaton rluvaton closed this Oct 24, 2023
@rluvaton rluvaton deleted the fix-test-release-test branch October 24, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rluvaton @richardlau @nodejs-github-bot