doc: the GN files should use Node's license #50694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
/cc @joyeecheung |
nodejs-github-bot
added
lib / src
lpinca
approved these changes
Dec 25, 2023
bnb
approved these changes
Dec 26, 2023
github-actions
bot
removed
the
request-ci
UlisesGascon
approved these changes
Dec 26, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in df16c69 |
|
On a side note, this was merged despite the commit message being invalid as per our guidelines. |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #50694 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Merged
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Jan 21, 2024
This file was missed in nodejs#50694.
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 2, 2024
This file was missed in nodejs#50694. PR-URL: nodejs#51535 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Feb 9, 2024
This file was missed in nodejs#50694. PR-URL: nodejs#51535 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 19, 2024
This file was missed in nodejs#50694. PR-URL: nodejs#51535 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50694 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50694 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #47637 (comment).
Remove the copyright headers in the GN files since they should just be licensed under Node's license file. (Those files were written by Electron team from scratch up.)
The
gypi_to_gn.pyscript comes from Chromium and an entry for it has been added inlicense-builder.sh.