Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace foreach test-stream-pipe-unpipe-stream.js #50786

Merged
merged 5 commits into from
May 12, 2024
Merged

test: replace foreach test-stream-pipe-unpipe-stream.js #50786

merged 5 commits into from
May 12, 2024

Conversation

DevPres
Copy link
Contributor

@DevPres DevPres commented Nov 18, 2023 •
edited

This PR replace forEach() with for..of cycle.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2023
RafaelGSS
RafaelGSS requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the lint issues and include email and username to git commit. Can you --resetAuthor after configuring your git? (git config user.name ...)

@DevPres
Copy link
Contributor Author

DevPres commented Nov 25, 2023

Hi @RafaelGSS , i fix the lint issue, and set git config. Let me know if it's ok. Thanks for your revision

RafaelGSS
RafaelGSS reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DevPres, looks like you'll need to squash your commits into one. Can you do that?

@DevPres
Copy link
Contributor Author

DevPres commented Nov 28, 2023

@RafaelGSS Did it! let me know if it's ok! thank for your time!

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2023
RafaelGSS
RafaelGSS reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR changes a bit more than forEach -> for .. of. Can you revert the unrelated changes?

@RafaelGSS RafaelGSS removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2023
lpinca
lpinca approved these changes Dec 15, 2023
View reviewed changes
test/parallel/test-stream-pipe-unpipe-streams.js Outdated Show resolved Hide resolved
test/parallel/test-stream-pipe-unpipe-streams.js Outdated Show resolved Hide resolved
test/parallel/test-stream-pipe-unpipe-streams.js Outdated Show resolved Hide resolved
test/parallel/test-stream-pipe-unpipe-streams.js Outdated Show resolved Hide resolved
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2023 •
edited by jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/56447/ 💛

@jasnell jasnell added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. and removed needs-ci PRs that need a full CI run. labels Dec 23, 2023
@aduh95
Copy link
Contributor

aduh95 commented May 3, 2024

@RafaelGSS are you still blocking this PR?

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58955/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58962/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58966/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58977/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58985/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59080/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59092/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59130/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59151/

@aduh95 aduh95 merged commit 06cde5c into nodejs:main May 12, 2024
50 checks passed
@aduh95
Copy link
Contributor

aduh95 commented May 12, 2024

Landed in 06cde5c

aduh95 pushed a commit that referenced this pull request May 12, 2024
@Ch3nYuY
test: replace forEach() in test-stream-pipe-unpipe-stream
7129915 
PR-URL: #50786
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request May 12, 2024
@DevPres @targos
test: replace forEach() in test-stream-pipe-unpipe-stream
cd00cdc 
PR-URL: #50786
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
@DevPres @lukins-cz
test: replace forEach() in test-stream-pipe-unpipe-stream
646d9a3 
PR-URL: nodejs#50786
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@DevPres @nodejs-github-bot @aduh95 @jasnell @lpinca @RafaelGSS @marco-ippolito