lib: refactor to use validateFunction in diagnostics_channel #50955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use validateFunction to remove duplicate implementation.
nodejs-github-bot
added
diagnostics_channel
lpinca
approved these changes
Nov 28, 2023
deokjinkim
added
request-ci
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Nov 29, 2023
aduh95
added
the
commit-queue
JungMinu
approved these changes
Nov 29, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in e1bfd0a |
targos
pushed a commit
that referenced
this pull request
Dec 4, 2023
Use validateFunction to remove duplicate implementation. PR-URL: #50955 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Use validateFunction to remove duplicate implementation. PR-URL: #50955 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use validateFunction to remove duplicate implementation.