net: add new connection attempts events #51045

ShogunPanda · 2023-12-04T15:58:20Z

This PR adds three new events in the net.createConnection flow:

connectionAttempt: Emitted when a new connection attempt is established. In case of Happy Eyeballs, this might emitted multiple times.
connectionAttemptFailed: Emitted when a connection attempt failed. In case of Happy Eyeballs, this might emitted multiple times.
connectionAttemptTimeout: Emitted when a connection attempt timed out. In case of Happy Eyeballs, this will not be emitted for the last attempt. This is not emitted at all if Happy Eyeballs is not used.

Additionally, a previous bug has been fixed where a new connection attempt could have been started after a previous one failed and after the connection was destroyed by the user. This led to a failed assertion.
This bug was reported several times but all were marked duplicates of the issue below.

Note that without the new events (especially connectionAttemptTimeout) I think is impossible to correctly test the bugfix.

Fixes: #48763

nodejs-github-bot · 2023-12-04T15:58:25Z

Review requested:

@nodejs/net

ShogunPanda · 2023-12-04T15:58:51Z

CC: @bnoordhuis @tniessen @lpinca @mcollina

nodejs-github-bot · 2023-12-04T16:01:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56075/

nodejs-github-bot · 2023-12-05T11:33:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56101/

nodejs-github-bot · 2023-12-05T14:20:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56103/

nodejs-github-bot · 2023-12-05T17:17:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56104/

nodejs-github-bot · 2023-12-06T11:55:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56127/

mcollina

lgtm

lpinca · 2023-12-09T06:32:11Z

I would not make these events public. If Happy Eyeballs will be moved to a lower level (libuv) in the future, it will be complex/useless to keep supporting them.

ShogunPanda · 2023-12-09T09:01:09Z

@lpinca Are you just talking about removing them from the documentation?

lpinca · 2023-12-09T09:49:24Z

Yes, or using private symbols. We can make them public later, if needed.

jasnell · 2023-12-09T15:43:03Z

doc/api/net.md

+Emitted when a connection attempt failed. This may be emitted multiple times
+if the family autoselection algorithm is enabled in [`socket.connect(options)`][].
+
+### Event: `'connectionAttemptFailed'`


Should this be connectionAttemptTimeout or whatever the third event was called. This appears to be an accidental duplication?

Yes it is. Copy and paste lazyness. Fixed now.

jasnell

One doc nit that needs fixing, otherwise LGTM

jasnell · 2023-12-09T15:48:00Z

If Happy Eyeballs will be moved to a lower level (libuv) in the future, it will be complex/useless to keep supporting them.

I presume these are added now because they are useful/needed now. Whether happy eyeballs is ever moved into libuv is still hypothetical AFAIK. I would rather not gate on this based on that hypothetical. We can deprecate these events in the future if necessary.

lpinca · 2023-12-09T18:11:05Z

I have no objections, but if the events are only needed internally for testing/debugging why making them public? If people start using/abusing them, it will be hard to deprecate/remove them.

ShogunPanda · 2023-12-11T13:51:16Z

@lpinca The events are, in my opinion, not just needed internally. At the moment we don't really have any events other than error and timeout (which are general purpose and operate on the higher level) to track what happens when establishing the connection. So I added them. Do you think are they dangerous in any way?

PR-URL: #51045 Fixes: #48763 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Notable changes: doc: * (SEMVER-MINOR) add documentation for --build-snapshot-config (Anna Henningsen) #50453 lib,src,permission: * (SEMVER-MINOR) port path.resolve to C++ (Rafael Gonzaga) #50758 net: * (SEMVER-MINOR) add connection attempt events (Paolo Insogna) #51045 src: * (SEMVER-MINOR) support configurable snapshot (Joyee Cheung) #50453 src,permission: * (SEMVER-MINOR) add --allow-addon flag (Rafael Gonzaga) #51183 timers: * (SEMVER-MINOR) export timers.promises (Marco Ippolito) #51246 PR-URL: TODO

Notable changes: doc: * (SEMVER-MINOR) add documentation for --build-snapshot-config (Anna Henningsen) #50453 lib,src,permission: * (SEMVER-MINOR) port path.resolve to C++ (Rafael Gonzaga) #50758 net: * (SEMVER-MINOR) add connection attempt events (Paolo Insogna) #51045 src: * (SEMVER-MINOR) support configurable snapshot (Joyee Cheung) #50453 src,permission: * (SEMVER-MINOR) add --allow-addon flag (Rafael Gonzaga) #51183 timers: * (SEMVER-MINOR) export timers.promises (Marco Ippolito) #51246 PR-URL: #51342 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

Notable changes: doc: * (SEMVER-MINOR) add documentation for --build-snapshot-config (Anna Henningsen) nodejs#50453 lib,src,permission: * (SEMVER-MINOR) port path.resolve to C++ (Rafael Gonzaga) nodejs#50758 net: * (SEMVER-MINOR) add connection attempt events (Paolo Insogna) nodejs#51045 src: * (SEMVER-MINOR) support configurable snapshot (Joyee Cheung) nodejs#50453 src,permission: * (SEMVER-MINOR) add --allow-addon flag (Rafael Gonzaga) nodejs#51183 timers: * (SEMVER-MINOR) export timers.promises (Marco Ippolito) nodejs#51246 PR-URL: nodejs#51342 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

Notable changes: doc: * (SEMVER-MINOR) add documentation for --build-snapshot-config (Anna Henningsen) #50453 lib,src,permission: * (SEMVER-MINOR) port path.resolve to C++ (Rafael Gonzaga) #50758 net: * (SEMVER-MINOR) add connection attempt events (Paolo Insogna) #51045 src: * (SEMVER-MINOR) support configurable snapshot (Joyee Cheung) #50453 src,permission: * (SEMVER-MINOR) add --allow-addon flag (Rafael Gonzaga) #51183 timers: * (SEMVER-MINOR) export timers.promises (Marco Ippolito) #51246 PR-URL: #51342 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

Semigradsky · 2024-01-15T15:32:05Z

doc/api/net.md

+added: REPLACEME
+-->
+
+* `ip` {number} The IP which the socket is attempting to connect to.


@ShogunPanda Looks like it should be * address {string}. Not number.

You are right. This has been fixed in #51490.

Notable changes: doc: * (SEMVER-MINOR) add documentation for --build-snapshot-config (Anna Henningsen) nodejs#50453 lib,src,permission: * (SEMVER-MINOR) port path.resolve to C++ (Rafael Gonzaga) nodejs#50758 net: * (SEMVER-MINOR) add connection attempt events (Paolo Insogna) nodejs#51045 src: * (SEMVER-MINOR) support configurable snapshot (Joyee Cheung) nodejs#50453 src,permission: * (SEMVER-MINOR) add --allow-addon flag (Rafael Gonzaga) nodejs#51183 timers: * (SEMVER-MINOR) export timers.promises (Marco Ippolito) nodejs#51246 PR-URL: nodejs#51342 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

bradzacher · 2024-02-05T05:55:41Z

This looks like it's been baking in v21.6.0 for a few weeks now - is it going to be back-ported to v20 at all? (I noticed the lts-watch tag so I assume "probably"?)
If yes - is there a rough timeline on that?

ShogunPanda · 2024-02-05T14:59:32Z

It should: I think this will happen in couple of weeks.

lamuertepeluda · 2024-02-15T08:10:59Z

It should: I think this will happen in couple of weeks.

it didn't get merged yet with the latest v20.11.1, didn't it? 🫤

marco-ippolito · 2024-02-15T08:22:17Z

It should: I think this will happen in couple of weeks.

it didn't get merged yet with the latest v20.11.1, didn't it? 🫤

No it was a security release, there will be a release in a couple of weeks

ArnoldZokas · 2024-03-01T12:24:19Z

@marco-ippolito any news on the next 20.x release? There is no release proposal for it yet, so at least another two weeks?

jakubm-canva · 2024-03-24T21:33:46Z

@marco-ippolito could you please provide an update. We're now approaching 4 weeks since the latest update requests, which remained unanswered.

PR-URL: #51045 Fixes: #48763 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

bradzacher · 2024-03-26T21:18:04Z

Looks like this has released in 20.12.0
https://nodejs.org/en/blog/release/v20.12.0#new-connection-attempt-events

nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Dec 4, 2023

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2023

ShogunPanda force-pushed the no-attempts-when-aborted branch from e372bf7 to 7546326 Compare December 5, 2023 11:27

ShogunPanda requested a review from aduh95 December 5, 2023 11:27

ShogunPanda changed the title ~~net: do not attempt new connections when aborted~~ net: added new connection attempts events Dec 5, 2023

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2023

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2023

mcollina approved these changes Dec 7, 2023

View reviewed changes

jasnell reviewed Dec 9, 2023

View reviewed changes

jasnell approved these changes Dec 9, 2023

View reviewed changes

ShogunPanda force-pushed the no-attempts-when-aborted branch from aa8f6f8 to de721be Compare December 11, 2023 13:54

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2023

tniessen mentioned this pull request Dec 25, 2023

ERR_INTERNAL_ASSERTION #51285

Closed

RafaelGSS mentioned this pull request Jan 2, 2024

v21.6.0 proposal #51342

Merged

tsightler mentioned this pull request Jan 8, 2024

RIng Server Failure with latest Node.JS dgreif/ring#1383

Closed

1 task

aduh95 mentioned this pull request Jan 10, 2024

ERR_INTERNAL_ASSERTION with Strapi CLI #51354

Closed

derrickmehaffy mentioned this pull request Jan 12, 2024

Strapi crash - ERR_INTERNAL_ASSERTION: This is caused by either a bug in Node.js or incorrect usage of Node.js internals. strapi/strapi#18084

Closed

Semigradsky reviewed Jan 15, 2024

View reviewed changes

deejay1 mentioned this pull request Feb 7, 2024

After migration from v1 to v2 silently fails gradle/wrapper-validation-action#174

Closed

legobeat mentioned this pull request Feb 16, 2024

Revert "chore: update Node.js to v20 (#22755)" MetaMask/metamask-extension#22989

Closed

13 tasks

richardlau mentioned this pull request Mar 25, 2024

v20.12.0 proposal #52212

Merged

nalinbhardwaj mentioned this pull request Mar 26, 2024

Node bug? daimo-eth/daimo#908

Open

Linkgoron mentioned this pull request Apr 2, 2024

Uncaught Exception: This is caused by either a bug in Node.js or incorrect usage of Node.js internals #52319

Closed

jakubm-canva mentioned this pull request Apr 4, 2024

nodejs_20: 20.11.1 -> 20.12.0 NixOS/nixpkgs#299327

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: add new connection attempts events #51045

net: add new connection attempts events #51045

ShogunPanda commented Dec 4, 2023 •

edited

nodejs-github-bot commented Dec 4, 2023

ShogunPanda commented Dec 4, 2023

nodejs-github-bot commented Dec 4, 2023

nodejs-github-bot commented Dec 5, 2023

nodejs-github-bot commented Dec 5, 2023

nodejs-github-bot commented Dec 5, 2023

nodejs-github-bot commented Dec 6, 2023

mcollina left a comment

lpinca commented Dec 9, 2023

ShogunPanda commented Dec 9, 2023

lpinca commented Dec 9, 2023 •

edited

jasnell Dec 9, 2023

ShogunPanda Dec 11, 2023

jasnell left a comment

jasnell commented Dec 9, 2023

lpinca commented Dec 9, 2023

ShogunPanda commented Dec 11, 2023

Semigradsky Jan 15, 2024

ShogunPanda Jan 16, 2024

bradzacher commented Feb 5, 2024 •

edited

ShogunPanda commented Feb 5, 2024

lamuertepeluda commented Feb 15, 2024

marco-ippolito commented Feb 15, 2024

ArnoldZokas commented Mar 1, 2024

jakubm-canva commented Mar 24, 2024

bradzacher commented Mar 26, 2024

net: add new connection attempts events #51045

net: add new connection attempts events #51045

Conversation

ShogunPanda commented Dec 4, 2023 • edited

nodejs-github-bot commented Dec 4, 2023

ShogunPanda commented Dec 4, 2023

nodejs-github-bot commented Dec 4, 2023

nodejs-github-bot commented Dec 5, 2023

nodejs-github-bot commented Dec 5, 2023

nodejs-github-bot commented Dec 5, 2023

nodejs-github-bot commented Dec 6, 2023

mcollina left a comment

Choose a reason for hiding this comment

lpinca commented Dec 9, 2023

ShogunPanda commented Dec 9, 2023

lpinca commented Dec 9, 2023 • edited

jasnell Dec 9, 2023

Choose a reason for hiding this comment

ShogunPanda Dec 11, 2023

Choose a reason for hiding this comment

jasnell left a comment

Choose a reason for hiding this comment

jasnell commented Dec 9, 2023

lpinca commented Dec 9, 2023

ShogunPanda commented Dec 11, 2023

Semigradsky Jan 15, 2024

Choose a reason for hiding this comment

ShogunPanda Jan 16, 2024

Choose a reason for hiding this comment

bradzacher commented Feb 5, 2024 • edited

ShogunPanda commented Feb 5, 2024

lamuertepeluda commented Feb 15, 2024

marco-ippolito commented Feb 15, 2024

ArnoldZokas commented Mar 1, 2024

jakubm-canva commented Mar 24, 2024

bradzacher commented Mar 26, 2024

ShogunPanda commented Dec 4, 2023 •

edited

lpinca commented Dec 9, 2023 •

edited

bradzacher commented Feb 5, 2024 •

edited