Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix TestsStream parent class #51181

Merged
merged 1 commit into from Dec 18, 2023
Merged

doc: fix TestsStream parent class #51181

merged 1 commit into from Dec 18, 2023

Conversation

pluris
Copy link
Contributor

@pluris pluris commented Dec 16, 2023 •
edited by aduh95

As mentioned in the problem, the link was incorrect and has been fixed.

Fixes: #51174

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner labels Dec 16, 2023
@lpinca
Copy link
Member

lpinca commented Dec 16, 2023

I understand why you added "link" in the commit message but it is a bit confusing. How about "fix TestsStrem parent class"?

@pluris pluris changed the title doc: fix incorrect link for TestsStream doc: fix TestsStream parent class Dec 16, 2023
@pluris
Copy link
Contributor Author

pluris commented Dec 16, 2023

@lpinca I think the commit message you suggested is clearer.
Thank you for the comment. I fixed it.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit b931e61 into nodejs:main Dec 18, 2023
19 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b931e61

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@pluris @RafaelGSS
doc: fix TestsStream parent class
1c71435 
PR-URL: #51181
Fixes: #51174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@pluris @richardlau
doc: fix TestsStream parent class
184b8be 
PR-URL: #51181
Fixes: #51174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test_runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestStream is a Node stream but docs link to web ReadableStream
6 participants
@pluris @nodejs-github-bot @lpinca @MoLow @atlowChemi @aduh95