fs: add fast api for InternalModuleStat
#51344
Conversation
anonrig
added
the
performance
|
Review requested:
|
nodejs-github-bot
added
c++
src/node_file.cc
Outdated
| if (UNLIKELY(!env->permission()->is_granted( | ||
| permission::PermissionScope::kFileSystemRead, path))) { | ||
| options.fallback = true; | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
Just thinking about this, if this is true, it will:
- ignore the value -1.
- re-run
InternalModuleStatbut in the slower version. - throw error since the permission is not granted.
I don't know if worthy but maybe one test just to ensure this behavior, maybe a loop and then pass a value that is not allowed.
There was a problem hiding this comment.
I added a test (6 months later)
Failing because of the Node version: https://github.com/nodejs/node/actions/runs/7390448695/job/20105393172?pr=51344#step:6:5719 Who we should ping to solve this kind of issue? |
cc @nodejs/build @nodejs/npm Any suggestions on how to fix the error? |
|
There are two separate items in that log. First is a warning that will always show up when you're using a prerelease version of node. This is intentional to remind folks that they're in an unsupported prerelease version of node. npm still will install just fine, the part of npm that prevents itself from being installed globally in an unsupported node version throws a different exception and allows prereleases in its semver check against npm's engines field. The second error has to do with a missing file that is being required. As to why that file is missing, that's another mystery. It's definitely in the tarball of the published module, and in source control. |
|
The error must be related to the changes made in this PR. In other words, there's a bug in the implementation. |
|
This needs a rebase. |
anonrig
force-pushed
the
fast-api-internal-module-stat
branch
from
11cea33
to
3f32a24
Compare
anonrig
force-pushed
the
fast-api-internal-module-stat
branch
from
3f32a24
to
9b6a9f8
Compare
anonrig
force-pushed
the
fast-api-internal-module-stat
branch
from
9b6a9f8
to
1a71169
Compare
I don't know, but better ask our friend "benchmark ci": https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1570/ |
|
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1aa8a78 |
PR-URL: #51344 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: nodejs#51344 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: nodejs#51344 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Adds V8 Fast API to
InternalModuleStat