Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs,test: add URL to string to fs.watch #51346

Merged
merged 1 commit into from Jan 5, 2024
Merged

fs,test: add URL to string to fs.watch #51346

merged 1 commit into from Jan 5, 2024

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Jan 3, 2024 •
edited

I don't know if the URL is expected to be supported through fs.watch.

@nodejs/fs

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jan 3, 2024
@RafaelGSS
fs,test: add URL to string to fs.watch
c81d891 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
aduh95
aduh95 reviewed Jan 3, 2024
View reviewed changes
test/fixtures/permission/fs-read.js
@@ -265,6 +265,13 @@ const regularFile = __filename;
permission: 'FileSystemRead',
resource: path.toNamespacedPath(blockedFile),
}));
assert.throws(() => {
fs.watch(blockedFileURL, () => {});
}, common.expectsError({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the expectsError is unnecessary

Suggested change
}, common.expectsError({
}, {

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56652/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56655/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56665/

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit 22f4482 into nodejs:main Jan 5, 2024
53 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 22f4482

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@RafaelGSS @marco-ippolito
fs,test: add URL to string to fs.watch
14a649f 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: nodejs#51346
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@RafaelGSS @Medhansh404
fs,test: add URL to string to fs.watch
e925a59 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: nodejs#51346
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
@RafaelGSS @targos
fs,test: add URL to string to fs.watch
e8fffeb 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #51346
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@RafaelGSS @richardlau
fs,test: add URL to string to fs.watch
a75c72a 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #51346
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@RafaelGSS @richardlau
fs,test: add URL to string to fs.watch
4adea6c 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #51346
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@RafaelGSS @nodejs-github-bot @benjamingr @lpinca @anonrig @UlisesGascon @MoLow @aduh95