Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: removing common.expectsError since it's not needed anymore for asserts #51353

Merged
merged 2 commits into from Jan 7, 2024
Merged

test: removing common.expectsError since it's not needed anymore for asserts #51353

merged 2 commits into from Jan 7, 2024

Conversation

AndresMorelos
Copy link
Contributor

@AndresMorelos AndresMorelos commented Jan 3, 2024 •
edited

Since we can now pass an object as a second param for assert.throws function we don't need the common.expectsError function anymore,

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 3, 2024
@AndresMorelos
Copy link
Contributor Author

@RafaelGSS could you please take a look here?

@RafaelGSS RafaelGSS added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jan 3, 2024
@AndresMorelos AndresMorelos force-pushed the remove-common-expectsError-permissions-fs-write branch from e92b6c0 to 7d0e495 Compare January 3, 2024 19:30
@AndresMorelos
Copy link
Contributor Author

@RafaelGSS Commit message amended

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56653/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56656/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56662/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56667/

@RafaelGSS RafaelGSS added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 4, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56693/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2024
@nodejs-github-bot nodejs-github-bot merged commit 09a506f into nodejs:main Jan 7, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 09a506f

@AndresMorelos AndresMorelos deleted the remove-common-expectsError-permissions-fs-write branch January 8, 2024 00:14
@RafaelGSS RafaelGSS mentioned this pull request Jan 8, 2024
Merged
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@AndresMorelos @marco-ippolito
test: remove unneeded common.expectsError for asserts
c7f8dc4 
PR-URL: nodejs#51353
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@AndresMorelos @Medhansh404
test: remove unneeded common.expectsError for asserts
297952a 
PR-URL: nodejs#51353
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
@AndresMorelos @targos
test: remove unneeded common.expectsError for asserts
28c2bf3 
PR-URL: #51353
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@AndresMorelos @richardlau
test: remove unneeded common.expectsError for asserts
e1275d3 
PR-URL: #51353
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@AndresMorelos @richardlau
test: remove unneeded common.expectsError for asserts
954e2f2 
PR-URL: #51353
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

@trivikr trivikr trivikr approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AndresMorelos @nodejs-github-bot @lpinca @aduh95 @trivikr @RafaelGSS