test: fix flaky conditions for ppc64 SEA tests #51422

richardlau · 2024-01-10T12:29:11Z

In test status files, $system will be the OS and not the arch (which would be $arch).

Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le.

richardlau · 2024-01-10T12:31:31Z

test/sequential/sequential.status

@@ -47,8 +47,9 @@ test-watch-mode-inspect: SKIP
 # https://github.com/nodejs/node/issues/41286
 test-performance-eventloopdelay: PASS, FLAKY

-[$system==ppc || $system==ppc64]
+[$system==linux && $arch==ppc64]


re. $arch and the confusion in the previous PR's -- it looks like this should match process.arch:

node/tools/test.py

Lines 1676 to 1688 in e0b159e

archEngineContext = Execute([vm, "-p", "process.arch"], context)

vmArch = archEngineContext.stdout.rstrip()

if archEngineContext.exit_code != 0 or vmArch == "undefined":

print("Can't determine the arch of: '%s'" % vm)

print(archEngineContext.stderr.rstrip())

continue

env = {

'mode': mode,

'system': utils.GuessOS(),

'arch': vmArch,

'type': get_env_type(vm, options.type, context),

'asan': get_asan_state(),

}

which on ppc64le is ppc64:

[iojs@test-osuosl-rhel8-ppc64--le-2 ~]$ ./build/workspace/node-test-commit-plinux/nodes/rhel8-ppc64le/out/Release/node -p process.arch ppc64 [iojs@test-osuosl-rhel8-ppc64--le-2 ~]$

In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le.

github-actions · 2024-01-10T12:39:30Z

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

richardlau · 2024-01-10T13:13:08Z

FWIW https://ci.nodejs.org/job/node-test-commit-plinux/51647/nodes=rhel8-ppc64le/ is a CI on a temporary branch that is the current v21.6.0-proposal branch with the commit for this PR cherry-picked on top. The six failing single-executable-application tests are marked flaky and the job is overall marked yellow/unstable (as opposed to red/failed).

mhdawson

LGTM

nodejs-github-bot · 2024-01-10T18:51:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56734/

nodejs-github-bot · 2024-01-10T21:03:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56736/

nodejs-github-bot · 2024-01-10T21:54:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56738/

nodejs-github-bot · 2024-01-11T12:31:16Z

Landed in 273c892

In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: #51422 Refs: #50828 Refs: #50740 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: nodejs#51422 Refs: nodejs#50828 Refs: nodejs#50740 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le. PR-URL: #51422 Refs: #50828 Refs: #50740 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 10, 2024

richardlau commented Jan 10, 2024

View reviewed changes

richardlau mentioned this pull request Jan 10, 2024

v21.6.0 proposal #51342

Merged

test: fix flaky conditions for ppc64 SEA tests

87dd223

In test status files, `$system` will be the OS and not the arch (which would be `$arch`). Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le.

richardlau force-pushed the sea-ppc64 branch from 1d73d33 to 87dd223 Compare January 10, 2024 12:35

RafaelGSS approved these changes Jan 10, 2024

View reviewed changes

RafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 10, 2024

richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2024

This comment was marked as outdated.

Sign in to view

mhdawson approved these changes Jan 10, 2024

View reviewed changes

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2024

This comment was marked as outdated.

Sign in to view

anonrig approved these changes Jan 10, 2024

View reviewed changes

joyeecheung approved these changes Jan 10, 2024

View reviewed changes

lpinca approved these changes Jan 10, 2024

View reviewed changes

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2024

nodejs-github-bot merged commit 273c892 into nodejs:main Jan 11, 2024
62 checks passed

richardlau deleted the sea-ppc64 branch January 11, 2024 12:33

richardlau mentioned this pull request Mar 25, 2024

v20.12.0 proposal #52212

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix flaky conditions for ppc64 SEA tests #51422

test: fix flaky conditions for ppc64 SEA tests #51422

richardlau commented Jan 10, 2024 •

edited

Loading

richardlau Jan 10, 2024

github-actions bot commented Jan 10, 2024

This comment was marked as outdated.

richardlau commented Jan 10, 2024

mhdawson left a comment

This comment was marked as outdated.

nodejs-github-bot commented Jan 10, 2024

nodejs-github-bot commented Jan 10, 2024

nodejs-github-bot commented Jan 10, 2024

nodejs-github-bot commented Jan 11, 2024

	archEngineContext = Execute([vm, "-p", "process.arch"], context)
	vmArch = archEngineContext.stdout.rstrip()
	if archEngineContext.exit_code != 0 or vmArch == "undefined":
	print("Can't determine the arch of: '%s'" % vm)
	print(archEngineContext.stderr.rstrip())
	continue
	env = {
	'mode': mode,
	'system': utils.GuessOS(),
	'arch': vmArch,
	'type': get_env_type(vm, options.type, context),
	'asan': get_asan_state(),
	}

test: fix flaky conditions for ppc64 SEA tests #51422

test: fix flaky conditions for ppc64 SEA tests #51422

Conversation

richardlau commented Jan 10, 2024 • edited Loading

richardlau Jan 10, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 10, 2024

This comment was marked as outdated.

richardlau commented Jan 10, 2024

mhdawson left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

nodejs-github-bot commented Jan 10, 2024

nodejs-github-bot commented Jan 10, 2024

nodejs-github-bot commented Jan 10, 2024

nodejs-github-bot commented Jan 11, 2024

richardlau commented Jan 10, 2024 •

edited

Loading