Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure there's a channel before trying to send on it #5148

Closed
wants to merge 1 commit into from
Closed

Ensure there's a channel before trying to send on it #5148

wants to merge 1 commit into from

Conversation

arlolra
Copy link
Contributor

@arlolra arlolra commented Feb 9, 2016

Here's a trace on v0.12.9,

AssertionError: null == true
    at process.target._send (child_process.js:420:5)
    at process.<anonymous> (child_process.js:396:12)
    at process.emit (events.js:129:20)
    at handleMessage (child_process.js:324:10)
    at Pipe.channel.onread (child_process.js:350:11)

_disconnect nulls out the channel, but admits there may still be some buffering. If that's a NODE_HANDLE message, it'll attempt this ack. handleMessage has a similar check.

cc/ @inez

@mscdex mscdex added child_process Issues and PRs related to the child_process subsystem. v0.12 labels Feb 9, 2016
@mscdex
Copy link
Contributor

mscdex commented Feb 9, 2016

Maybe it would be easier to backport #4418? That way there's less of a delta between v0.12 and modern branches. I'm kind of surprised it wasn't already backported really.

I wonder if v0.10 needs this as well....

@arlolra
Copy link
Contributor Author

arlolra commented Feb 9, 2016

@mscdex definitely backport and abandon this. And it does look like v0.10 needs it as well.

@mscdex
Copy link
Contributor

mscdex commented Feb 9, 2016

v0.12 should be fixed by #5153. I wasn't able to reproduce the problem on v0.10.

@arlolra
Copy link
Contributor Author

arlolra commented Feb 9, 2016

Closing in favour of #5153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants