Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix dns.lookup family 0 and all description #51653

Merged
merged 3 commits into from
May 11, 2024
Merged

doc: fix dns.lookup family 0 and all description #51653

merged 3 commits into from
May 11, 2024

Conversation

domdomegg
Copy link
Contributor

@domdomegg domdomegg commented Feb 3, 2024 •
edited by aduh95

Fixes: #51482

Also see #51483, #51517

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Feb 3, 2024
@domdomegg domdomegg changed the title doc: fix dns.lookup family 0 and all description doc: fix dns.lookup family 0 and all description Feb 3, 2024
ShogunPanda
ShogunPanda approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 11, 2024
@aduh95 aduh95 merged commit 6e07a76 into nodejs:main May 11, 2024
20 checks passed
@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

Landed in 6e07a76

targos pushed a commit that referenced this pull request May 12, 2024
@domdomegg @targos
doc: fix dns.lookup family 0 and all descriptions
030f56e 
PR-URL: #51653
Fixes: #51482
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
@domdomegg @lukins-cz
doc: fix dns.lookup family 0 and all descriptions
93d9e60 
PR-URL: nodejs#51653
Fixes: nodejs#51482
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: dns docs for family = 0 and all = true is potentially misleading
4 participants
@domdomegg @nodejs-github-bot @aduh95 @ShogunPanda