src: implement v8 array iteration using the new callback-based API #51758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this to iterate over an array can be faster than calling Array::Get repeatedly. Local experiment shows that this is faster once the array size is bigger than 2.
nodejs-github-bot
added
c++
targos
reviewed
Feb 14, 2024
anonrig
approved these changes
Feb 16, 2024
github-actions
bot
removed
the
request-ci
legendecas
reviewed
Feb 20, 2024
legendecas
approved these changes
Feb 22, 2024
joyeecheung
added a commit
that referenced
this pull request
Feb 22, 2024
Using this to iterate over an array can be faster than calling Array::Get repeatedly. Local experiment shows that this is faster once the array size is bigger than 2. PR-URL: #51758 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
joyeecheung
added a commit
that referenced
this pull request
Feb 22, 2024
PR-URL: #51758 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
|
Landed in d51a74a...1a8ae9d |
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
Using this to iterate over an array can be faster than calling Array::Get repeatedly. Local experiment shows that this is faster once the array size is bigger than 2. PR-URL: #51758 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
PR-URL: #51758 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito
added
dont-land-on-v21.x
|
@joyeecheung can you backport on 21 please, it seems to fail compilation https://github.com/nodejs/node/actions/runs/8049258088/job/21982250897 |
marco-ippolito
added
the
backport-requested-v21.x
targos
added
dont-land-on-v21.x
|
This can't be backported as it relies on V8 API that doesn't exist on v21.x |
targos
added
dont-land-on-v18.x
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
Using this to iterate over an array can be faster than calling Array::Get repeatedly. Local experiment shows that this is faster once the array size is bigger than 2. PR-URL: nodejs#51758 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#51758 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
joyeecheung
added a commit
to joyeecheung/node
that referenced
this pull request
Jun 18, 2024
This backports nodejs#51758 which relies on an V8 API that's not available on v20.x. Original commit message: src: implement v8 array iteration using the new callback-based API Using this to iterate over an array can be faster than calling Array::Get repeatedly. Local experiment shows that this is faster once the array size is bigger than 2. PR-URL: nodejs#51758 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src: implement v8 array iteration using the new callback-based API
Using this to iterate over an array can be faster than calling
Array::Get repeatedly. Local experiment shows that this is faster
once the array size is bigger than 2.
src: use callback-based array iteration in Blob