build: handle aarch64 as arm64 #5191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
LGTM |
jbergstroem
force-pushed
the
fix/aarch64-arm64
branch
from
ef27f0b
to
f3aa718
Compare
`Makefile` is now consistent with `configure` regarding how we treat aarch64. PR-URL: nodejs#5191 Fixes: nodejs#5175 Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jbergstroem
force-pushed
the
fix/aarch64-arm64
branch
from
f3aa718
to
f167207
Compare
|
LGTM |
stefanmb
pushed a commit
to stefanmb/node
that referenced
this pull request
Feb 23, 2016
`Makefile` is now consistent with `configure` regarding how we treat aarch64. PR-URL: nodejs#5191 Fixes: nodejs#5175 Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
@nodejs/lts should we include this in v4.4.0? |
|
risk is very low so I'd say yes to lts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefileis now consistent withconfigureon how we treat aarch64.Refs #5175.
/r=@nodejs/build.