Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix reading empty string views in Blob[De]serializer #52000

Merged
merged 2 commits into from
Mar 10, 2024
Merged

src: fix reading empty string views in Blob[De]serializer #52000

merged 2 commits into from
Mar 10, 2024

Commits on Mar 7, 2024

  1. src: fix reading empty string views in Blob[De]serializer 

    The string writing/reading was intended for debugging info
in snapshot, which had a CHECK_GT(length, 0) check, it then
got repurposed for SEA resource writing/reading and turned
into a helper for string views, but was not updated to handle
empty views, causing occasional crash in the CI when the
read is protected. This patch fixes it.
    @joyeecheung
    joyeecheung committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    f9d846f View commit details
    Browse the repository at this point in the history

  2. fixup! src: fix reading empty string views in Blob[De]serializer

    @joyeecheung
    joyeecheung committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    66281f7 View commit details
    Browse the repository at this point in the history