Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: fix input validation in crypto.hash #52070

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 13, 2024

The documentation was wrong as it was mentioning ArrayBuffer, and the error message was wrong as it wasn't mentioning string.

Fixes: https://github.com/nodejs/node/pull/51044/files#r1522362983

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Mar 13, 2024
@H4ad H4ad added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 21, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 21, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/52070
✔  Done loading data for nodejs/node/pull/52070
----------------------------------- PR info ------------------------------------
Title      crypto: fix `input` validation in `crypto.hash` (#52070)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:crypto-hash-input-validation -> nodejs:main
Labels     crypto, author ready, needs-ci
Commits    1
 - crypto: fix `input` validation in `crypto.hash`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/52070
Fixes: https://github.com/nodejs/node/pull/51044/files#r1522362983
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52070
Fixes: https://github.com/nodejs/node/pull/51044/files#r1522362983
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 13 Mar 2024 10:43:24 GMT
   ✔  Approvals: 2
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52070#pullrequestreview-1935501284
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52070#pullrequestreview-1940343564
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-03-15T20:05:29Z: https://ci.nodejs.org/job/node-test-pull-request/57770/
- Querying data for job/node-test-pull-request/57770/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 52070
From https://github.com/nodejs/node
 * branch                  refs/pull/52070/merge -> FETCH_HEAD
✔  Fetched commits as 0a252c23d904..67bed235d4fb
--------------------------------------------------------------------------------
Auto-merging doc/api/crypto.md
[main f90feb8b5b] crypto: fix `input` validation in `crypto.hash`
 Author: Antoine du Hamel 
 Date: Wed Mar 13 11:39:22 2024 +0100
 1 file changed, 2 insertions(+), 3 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
crypto: fix `input` validation in `crypto.hash`

PR-URL: #52070
Fixes: https://github.com/nodejs/node/pull/51044/files#r1522362983
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[main 1301154046] crypto: fix input validation in crypto.hash
Author: Antoine du Hamel duhamelantoine1995@gmail.com
Date: Wed Mar 13 11:39:22 2024 +0100
1 file changed, 2 insertions(+), 3 deletions(-)
✖ 13011540468129074b6f4ee7ab6f2dc5f65cf4c9
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✖ 2:7 Fixes must be a GitHub URL. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/8373759766

@aduh95 aduh95 merged commit 6dd1c75 into nodejs:main Mar 21, 2024
68 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 21, 2024

Landed in 6dd1c75

@aduh95 aduh95 deleted the crypto-hash-input-validation branch March 21, 2024 11:12
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
PR-URL: nodejs#52070
Refs: https://github.com/nodejs/node/pull/51044/files#r1522362983
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
PR-URL: #52070
Refs: https://github.com/nodejs/node/pull/51044/files#r1522362983
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
PR-URL: #52070
Refs: https://github.com/nodejs/node/pull/51044/files#r1522362983
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants