Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update collaborator email #52088

Merged
merged 1 commit into from Mar 16, 2024
Merged

doc: update collaborator email #52088

merged 1 commit into from Mar 16, 2024

Conversation

ruyadorno
Copy link
Member

Updating my email on the relevant places.

@ruyadorno
doc: update collaborator email
e7600d9 
Updating my email on the relevant places.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Mar 14, 2024
@richardlau
Copy link
Member

@ruyadorno You might want to update your entries in https://github.com/nodejs/email/blob/main/iojs.org/aliases.json as well.

@ruyadorno
Copy link
Member Author

@ruyadorno You might want to update your entries in https://github.com/nodejs/email/blob/main/iojs.org/aliases.json as well.

Thanks @richardlau!

@aduh95

This comment was marked as resolved.

Sign in to view
@aduh95 aduh95 mentioned this pull request Mar 14, 2024
Merged
@ruyadorno
Copy link
Member Author

In case you missed it, there's also the release key that mentions another email:

node/README.md

Line 774 in 73025c4

* **Ruy Adorno** <<ruyadorno@hotmail.com>>

I think that one is correct since that's the email associated with that GPG key 😊

richardlau pushed a commit to nodejs/email that referenced this pull request Mar 15, 2024
@ruyadorno
email: update ruyadorno email (#241)
6ab0edb 
Refs: nodejs/node#52088 (comment)
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 15, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 16, 2024
@nodejs-github-bot nodejs-github-bot merged commit dafe004 into nodejs:main Mar 16, 2024
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in dafe004

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@ruyadorno @rdw-msft
doc: update collaborator email
c304ccb 
Updating my email on the relevant places.

PR-URL: nodejs#52088
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ruyadorno @richardlau @aduh95 @nodejs-github-bot @GeoffreyBooth @lpinca @legendecas