Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve event-loop promise state tracking #52108

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: improve event-loop promise state tracking #52108

merged 1 commit into from
May 6, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Mar 15, 2024 •
edited

Fixes #43655
Fixes #34851
Superseeds #34862

@nodejs/performance

Can you help me with the changes in my last commit? I adapted changes from #34862. This should improve the performance of rejected promises. Maybe you have some concerns regarding the the changes. I am not that convinced from the last commit.

Ty

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Mar 15, 2024
@Uzlopak Uzlopak changed the title chore: improve event-loop chore: improve event-loop promise state tracking Mar 15, 2024
@Uzlopak Uzlopak force-pushed the improve-event-loop branch 3 times, most recently from b4b0a4c to d221af4 Compare March 16, 2024 03:02
@Uzlopak Uzlopak mentioned this pull request Mar 17, 2024
Open
@Uzlopak Uzlopak changed the title chore: improve event-loop promise state tracking fix: improve event-loop promise state tracking Mar 17, 2024
@Uzlopak Uzlopak requested a review from aduh95 March 17, 2024 17:07
mcollina
mcollina approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024
@mcollina
Copy link
Member

mcollina commented Mar 18, 2024 •
edited

I think we should remove multipleResolves event in a follow-up PR.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57801/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57840/

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Mar 20, 2024

@mcollina
@anonrig

Is there something i have to do?

@aduh95
Copy link
Contributor

aduh95 commented Mar 20, 2024

Yes, the added test is flaky:

not ok 2290 parallel/test-promise-unhandled-issue-43655
  ---
  duration_ms: 1031.49800
  severity: fail
  exitcode: 1
  stack: |-
    node:internal/process/promises:417
        triggerUncaughtException(err, true /* fromPromise */);
        ^
    
    AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    
      assert.ok(Date.now() - time0 < 10)
    
        at test (/Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/test/parallel/test-promise-unhandled-issue-43655.js:23:10) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: false,
      expected: true,
      operator: '=='
    }
    
    Node.js v22.0.0-pre
  ...

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57865/

@Uzlopak

This comment was marked as outdated.

Sign in to view
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Mar 21, 2024

It should be now less flaky.

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2024
mcollina
mcollina approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58178/

mertcanaltin
mertcanaltin approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Apr 23, 2024

@mcollina
@RafaelGSS

macOs test seems to have a flaky test.

This PR needs now request-ci?

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58645/

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Apr 24, 2024

Are the test failures related to my patch? I have no osx-arm machine to check it.

@Uzlopak Uzlopak force-pushed the improve-event-loop branch 2 times, most recently from 71b3502 to 691b724 Compare April 24, 2024 12:27
@BridgeAR
Copy link
Member

@Uzlopak they do not seem to be related

@Uzlopak
Copy link
Contributor Author

Uzlopak commented May 6, 2024

@BridgeAR
PTAL

benjamingr
benjamingr approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still lgtm

@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58983/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58989/

@Uzlopak
Copy link
Contributor Author

Uzlopak commented May 6, 2024

Whoa!!!! the CI is green. the CI is green!

@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit be8d64e into nodejs:main May 6, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in be8d64e

@Uzlopak Uzlopak deleted the improve-event-loop branch May 6, 2024 20:18
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@Uzlopak @Ch3nYuY
process: improve event-loop
900fb89 
PR-URL: nodejs#52108
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request May 8, 2024
@Uzlopak @targos
process: improve event-loop
0bbc62c 
PR-URL: #52108
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
@Uzlopak @lukins-cz
process: improve event-loop
ac0c277 
PR-URL: nodejs#52108
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
10 participants
@Uzlopak @mcollina @nodejs-github-bot @aduh95 @RafaelGSS @BridgeAR @benjamingr @anonrig @mertcanaltin @H4ad