Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: migrate ContextifyScript to cppgc #52295

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

wip: migrate ContextifyScript to cppgc #52295

wants to merge 3 commits into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Mar 31, 2024 •
edited

Not yet ready for review. This requires a pretty breaking V8 API change, so will need to figure out how it can land in the upstream first. Just opening a PR as a reference for upstream reviewers.

Local numbers:

                                                                                                                                    confidence improvement accuracy (*)   (**)  (***)
vm/compile-script-in-isolate-cache.js n=1000 filename='test/fixtures/snapshot/typescript.js' type='with-dynamic-import-callback'                   -0.91 %       ±1.84% ±2.45% ±3.20%
vm/compile-script-in-isolate-cache.js n=1000 filename='test/fixtures/snapshot/typescript.js' type='without-dynamic-import-callback'                -2.79 %       ±4.24% ±5.70% ±7.55%
vm/compile-script-in-isolate-cache.js n=1000 filename='test/fixtures/syntax/good_syntax.js' type='with-dynamic-import-callback'                     3.39 %       ±4.28% ±5.70% ±7.42%
vm/compile-script-in-isolate-cache.js n=1000 filename='test/fixtures/syntax/good_syntax.js' type='without-dynamic-import-callback'         ***      6.93 %       ±3.08% ±4.11% ±5.35%

@joyeecheung
src: add utilities for cppgc integration
2a1ce3a 
This adds a `node::CppgcMixin` and a few macros to help migrating
simpler BaseObjects to cppgc-based existing management.
@joyeecheung
deps: support v8::Data in v8::TracedHandle
3f2bc78
@joyeecheung
vm: migrate ContextifyScript to cppgc
a2cc905
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 31, 2024
@joyeecheung joyeecheung mentioned this pull request Mar 31, 2024
Open
@joyeecheung
Copy link
Member Author

Blocked on https://chromium-review.googlesource.com/c/v8/v8/+/5403888 (and maybe https://chromium-review.googlesource.com/c/v8/v8/+/5447348 too)

hubot pushed a commit to v8/v8 that referenced this pull request May 2, 2024
@joyeecheung
[api] support v8::Data in v8::TracedReference and v8::EmbedderGraph
ab239f6 
Refs: nodejs/node#52295

Change-Id: If0e34519c4fa83b019a0a67136e6515d85810a19
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5403888
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#93690}
@joyeecheung
Copy link
Member Author

joyeecheung commented May 3, 2024 •
edited

https://chromium-review.googlesource.com/c/v8/v8/+/5403888 has landed but given that the upstream has deprecated the current wrapper descriptor-based integration and the new API requires a series of V8 changes to upgrade to, I think it would minify the risk of bugs if we wait until 12.5 is pulled in.

This was referenced May 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joyeecheung @nodejs-github-bot