Update devcontainer.json #52445
Open
Update devcontainer.json #52445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Apr 10, 2024
.devcontainer/devcontainer.json
Outdated
| } | ||
| }, | ||
| "runArgs": [ | ||
| // Allow node process to bind to port numbers below 1024 without root permissions |
There was a problem hiding this comment.
Suggested change
| // Allow node process to bind to port numbers below 1024 without root permissions |
There was a problem hiding this comment.
+1, I think JS comments are not valid JSON syntax.
There was a problem hiding this comment.
VSCode uses jsonc for its config files, so comments are not invalid in this case.
They also state this feature explicitly in the devcontainer.json spec.
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Adding stalled, as the comment was never addressed. |
RedYetiDev
added
review wanted
RedYetiDev
suggested changes
May 6, 2024
There was a problem hiding this comment.
Are the changes in this file relevant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update includes the addition of "runArgs" to specify Docker run arguments. Specifically, it allows the Node.js process inside the container to bind to port numbers below 1024 without requiring root permissions. This should resolve the issue with "Reopen in Container" in VS Code. Adjustments can be made based on the specific requirements.