lib: simplify primordial safe generation

[RedYetiDev]

Simplify primordial generation using of ObjectEntries

Caution

For security reasons regarding prototype pollution, using of is generally considered bad practice, but at this point in time, the user does not have access to the prototype of ObjectEntries (object).

[RedYetiDev]

The following lint errors were triggered:

Error: 420:23 error Missing trailing comma comma-dangle

I can resolve this at a later point in time, as more edits to the file will probably be made

---

Error: 423:12 error Use object destructuring instead of array destructuring node-core/no-array-destructuring

This array destructure occurs before the user is able to override it, but I can change it if needed

---

Error: 423:39 error 'ObjectEntries' is not defined no-undef

Defined here

---

Error: 440:9 error 'SafePromise' is not defined no-undef

Defined here

---

Error: 455:13 error 'SafePromise' is not defined no-undef

Defined here

---

Error: 469:5 error 'SafePromise' is not defined no-undef

Defined here

---

Error: 532:5 error 'SafePromise' is not defined no-undef

Defined here

---

Error: 565:5 error 'SafePromise' is not defined no-undef

Defined here

---

Error: 578:5 error 'SafePromise' is not defined no-undef

Defined here

---

[RedYetiDev]

@aduh95, do you know the eslint comments to avoid some of these errors?

[aduh95]

@aduh95, do you know the eslint comments to avoid some of these errors?

You don't need ESLint commands, you need to refactor the code so it's valid JavaScript (when it comes to SafePromise not being defined, you need to define e.g. const SafePromise = primordials.SafePromise), or adapted to the style of the codebase (so adding the trailing comma, and refactor to use object destructuring instead of array destructuring). All the errors reported by ESLint are valid AFAICT.

You can use make lint-js-fix to apply ESLint autofixes, if that was what you were asking.

[benjamingr]

I'm not blocking, but I don't find this code more readable nor does the duplication bother me that much.

[RedYetiDev]

I'm not blocking, but I don't find this code more readable nor does the duplication bother me that much.

In my latest change, the code now matches the format for several other generations within the file

[aduh95]

Note that SafePromise used to not be on the primordials object, it was only used locally on that file; it probably makes sense to keep it that way.