Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: write tests for assertIsArray http2 util #52511

Merged
merged 1 commit into from Apr 15, 2024
Merged

test: write tests for assertIsArray http2 util #52511

merged 1 commit into from Apr 15, 2024

Conversation

sinansonmez
Copy link
Contributor

test: write tests for assertIsArray http2 util

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 13, 2024
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58344/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58346/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 15, 2024
@nodejs-github-bot nodejs-github-bot merged commit 1703ab5 into nodejs:main Apr 15, 2024
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1703ab5

aduh95 pushed a commit that referenced this pull request Apr 29, 2024
@sinansonmez @aduh95
test: write tests for assertIsArray http2 util
e34e0a9 
PR-URL: #52511
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95 aduh95 mentioned this pull request Apr 30, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@sinansonmez @marco-ippolito
test: write tests for assertIsArray http2 util
b0bdc91 
PR-URL: #52511
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@sinansonmez @marco-ippolito
test: write tests for assertIsArray http2 util
4ad159b 
PR-URL: #52511
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sinansonmez @nodejs-github-bot @benjamingr @lpinca @anonrig