test: skip test for dynamically linked OpenSSL #52542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a temporary measure to unblock the CI, skip the RSA implicit rejection test when Node.js is built against a dynamically linked OpenSSL.
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
targos
approved these changes
Apr 15, 2024
|
https://ci.nodejs.org/job/node-test-commit-linux-containered/42670/nodes=ubi81_sharedlibs_openssl111fips_x64/ ran and passed on test-digitalocean-ubi81_container-x64-1 which had started failing builds due to #52537. CI has failed for a different platform 😞. Subject to getting a passing CI I suggest we fast-track this as two of the three UBI 8 containers now fail builds due to #52537. |
richardlau
added
the
fast-track
|
Fast-track has been requested by @richardlau. Please 👍 to approve. |
aduh95
approved these changes
Apr 15, 2024
lpinca
approved these changes
Apr 15, 2024
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4ec049b |
richardlau
added a commit
that referenced
this pull request
Apr 17, 2024
As a temporary measure to unblock the CI, skip the RSA implicit rejection test when Node.js is built against a dynamically linked OpenSSL. PR-URL: #52542 Refs: #52537 Refs: nodejs-private/node-private#525 Refs: https://hackerone.com/reports/2269177 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau
added a commit
that referenced
this pull request
Apr 17, 2024
As a temporary measure to unblock the CI, skip the RSA implicit rejection test when Node.js is built against a dynamically linked OpenSSL. PR-URL: #52542 Refs: #52537 Refs: nodejs-private/node-private#525 Refs: https://hackerone.com/reports/2269177 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Apr 23, 2024
As a temporary measure to unblock the CI, skip the RSA implicit rejection test when Node.js is built against a dynamically linked OpenSSL. PR-URL: #52542 Refs: #52537 Refs: nodejs-private/node-private#525 Refs: https://hackerone.com/reports/2269177 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a temporary measure to unblock the CI, skip the RSA implicit rejection test when Node.js is built against a dynamically linked OpenSSL.
Refs: #52537
Refs: https://github.com/nodejs-private/node-private/pull/525
Refs: https://hackerone.com/reports/2269177