build: compile with C++20 support on Windows

[targos]

Our Linux build infra is not ready for it yet,
but V8 is making it difficult to compile on Windows
without it.

Refs: #45402

[nodejs-github-bot]

Review requested:

• @nodejs/gyp

[targos]

/cc @nodejs/build @nodejs/platform-windows

[targos]

@nodejs/tsc I'm labeling semver-major out of caution (IIRC common.gypi has an impact on native addons).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58525/

[richardlau]

I thought Windows was the remaining blocker for #45402? I think we have gcc 10 on all the Linux machines now but I'm wary of making this kind of switch across-the-board days before the Node.js 22 release.

Approving subject to passing CI.

[StefanStojanovic]

LGTM given that Windows CI passes. I'll use this change locally until it lands 👍

[targos]

@richardlau the last tentative on #45427 showed issues with Debian 12: #45427 (comment)

[targos]

OTOH you're right. This fails on Windows 🤔

[targos]

@StefanStojanovic There are a few errors. Here's one of them:

17:42:23 C:\workspace\node-compile-windows\node\deps\v8\src\compiler\turboshaft\assembler.h(4049,9): error C2614: 'v8::internal::compiler::turboshaft::TSAssembler<v8::internal::compiler::turboshaft::GraphVisitor,v8::internal::compiler::turboshaft::LateEscapeAnalysisReducer,v8::internal::compiler::turboshaft::MachineOptimizationReducer,v8::internal::compiler::turboshaft::MemoryOptimizationReducer,v8::internal::compiler::turboshaft::BranchEliminationReducer,v8::internal::compiler::turboshaft::LateLoadEliminationReducer,v8::internal::compiler::turboshaft::ValueNumberingReducer>': illegal member initialization: 'Assembler' is not a base or member [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_compiler.vcxproj]

[targos]

If it works with V8 12.4, I can add the commit to the other PR.

[StefanStojanovic]

@StefanStojanovic There are a few errors. Here's one of them:

17:42:23 C:\workspace\node-compile-windows\node\deps\v8\src\compiler\turboshaft\assembler.h(4049,9): error C2614: 'v8::internal::compiler::turboshaft::TSAssembler<v8::internal::compiler::turboshaft::GraphVisitor,v8::internal::compiler::turboshaft::LateEscapeAnalysisReducer,v8::internal::compiler::turboshaft::MachineOptimizationReducer,v8::internal::compiler::turboshaft::MemoryOptimizationReducer,v8::internal::compiler::turboshaft::BranchEliminationReducer,v8::internal::compiler::turboshaft::LateLoadEliminationReducer,v8::internal::compiler::turboshaft::ValueNumberingReducer>': illegal member initialization: 'Assembler' is not a base or member [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_compiler.vcxproj]

I'm seeing them too (locally added change in V8 v12.4 update branch)

If it works with V8 12.4, I can add the commit to the other PR.

Since v12.4 is the first one where I saw c++20 errors, I'll work on it with the changes from this PR. Once it is ready I'll open a PR to your branch as usual and will add this change either as part of that PR. I'll make it so there are 2 commits, one for c++20 and the other for V8, you can later decide to squash them or leave them both. Does this make sense?

[targos]

Perfect, thank you!

[targos]

Will be included in #52465