New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 12.4 #52465

Closed

targos wants to merge 15 commits into nodejs:main from targos:v8-124

Member

targos commented Apr 11, 2024

May replace #52293 directly if it doesn't introduce more build issues.

Collaborator

nodejs-github-bot commented Apr 11, 2024

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8-update

nodejs-github-bot added build needs-ci v8 engine labels

targos added the semver-major label

targos mentioned this pull request

deps: update V8 to 12.3 #52293

Closed

targos added the request-ci label

github-actions bot removed the request-ci label

Collaborator

nodejs-github-bot commented Apr 11, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58270/

Collaborator

nodejs-github-bot commented Apr 11, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5914/

Collaborator

nodejs-github-bot commented Apr 11, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5914/

Collaborator

nodejs-github-bot commented Apr 11, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5914/

targos mentioned this pull request

2024-04-24, Version 22.0.0 (Current) #52505

Merged

melroy89 commented Apr 17, 2024 •

edited

Loading

Uh, is Windows build now failing in CICD now?

targos added 10 commits

April 19, 2024 12:51


          deps: update V8 to 12.4.254.14

d887f85


          build: reset embedder string to "-node.0"

e4c6f08


          src: update NODE_MODULE_VERSION to 127

8d1bbf8

Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 12.4.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md


          deps: always define V8_EXPORT_PRIVATE as no-op

88a4285

dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>


          deps: silence irrelevant V8 warning

a41d78c

PR-URL: nodejs#45579
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>


          deps: disable V8 concurrent sparkplug compilation

1999abf

It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>


          deps: avoid compilation error with ASan

6be9104

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>


          deps: remove usage of a C++20 feature from V8

915255b

We are not ready to compile with C++20 support yet.
This is only a DCHECK that can be removed without affecting the behavior
of release builds.

PR-URL: nodejs#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>


          deps: patch V8 to avoid duplicated zlib symbol

c09d25f

PR-URL: nodejs#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>


          deps: silence internal V8 deprecation warning

2aa1874

PR-URL: nodejs#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

targos force-pushed the v8-124 branch from 4236aff to 3cf6888 Compare

April 19, 2024 10:56

Member Author

targos commented Apr 19, 2024 •

edited

Loading

@StefanStojanovic I updated the PR after #52293 landed.

targos added the request-ci label

github-actions bot removed the request-ci label

Collaborator

nodejs-github-bot commented Apr 19, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58521/

Collaborator

nodejs-github-bot commented Apr 19, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5927/

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

a234e25

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

a01fc72

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

62d784b

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

74d111f

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

22c12ad

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

12766b7

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

4a4844f

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

2f77489

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

targos pushed a commit that referenced this pull request


          deps: patch V8 to support compilation with MSVC

f034733

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: #52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

targos added a commit that referenced this pull request


          deps: V8: revert CL 5331688

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: #52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

targos pushed a commit to targos/node that referenced this pull request


          deps: patch V8 to support compilation with MSVC

2c7b779

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

targos added a commit to targos/node that referenced this pull request


          deps: V8: revert CL 5331688

1ec4108

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

9f54d2c

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

96b8198

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

db1f9af

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

3a3deea

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

2d83077

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

760347f

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

18b8140

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

f6f3821

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

45b4f79

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

d062c61

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

bf6cd9a

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

b781ff1

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

a0bcd75

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

7457e82

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

f430750

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: patch V8 to support compilation with MSVC

285e85b

After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request


          deps: V8: revert CL 5331688

d42c164

On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready build commit-queue-rebase needs-ci semver-major v8 engine