test: move parallels into subfolders #52859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
If this change is too big for one PR (which it probably is), splitting it up into one PR for each subsystem may be helpful. By the way, I know this change might seem unneeded and unhelpful, but I think it's important for the DX to find and access tests quickly. |
|
The PR in its current form is impossible to review so there's no way we can merge it. |
|
Thanks, @targos, |
IMHO the pros (that you mentioned when opening the PR) are greater than the cons |
|
Will do! I'm closing this PR, as its way too big, but I'll submit some smaller ones soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So... the
git blameis going to hate this. This PR is more of a dicussion for a potential possibility.Personally, I think that the
paralleltest folder is hard to work with, as it won't render in GitHub, and trying to find a specific test requires knowing exactly where to look in thousands of files.This possible change (which is giant) would organize the parallels into folders (Generated based on the filenames).
Currently, all the tests should pass, and it shouldn't interfere to much with the addition of more tests.