-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move 'http' tests into subfolder #52875
Conversation
30d835d
to
536fa73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Does it work well with the |
I updated the file, so it should work, but I haven't done hard testing |
Can you still run only "http" tests with |
It seems not, but I'll build a fix for that now |
Okay, now it is possible :-) |
@targos i'll test the |
|
@nodejs/http @nodejs/testing |
Requesting a CI, as this PR has two approves, and a CI is probably going to be needed before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm somewhat concerned that this would make backporting commits harder. I think we would need backport PRs done immediately for all lines (18, 20) before landing this.
Okay, I'll open backport PRs soon. |
This will add the initial support: #52901 |
@@ -112,4 +112,4 @@ test-inspector-async-hook-setup-at-inspect-brk: PASS, FLAKY | |||
|
|||
[$arch==loong64] | |||
# https://github.com/nodejs/node/issues/51662 | |||
test-http-correct-hostname: SKIP | |||
http/test-correct-hostname: SKIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http/test-correct-hostname: SKIP | |
http/test-correct-hostname: SKIP | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make these changes (and others) once this is unblocked
FWIW, many tests do not fit cleanly into any particular subsystem, and I don't see how we'd consistently apply There are almost 500 open PRs. Aside from backporting, we would need to ensure that PRs such as this one are not going to cause mass conflicts in dozens of other PRs. I am not in favor, but also not strongly opposed, assuming all relevant git and GitHub operations keep referring to the actual changes and not to the mass renames. |
It doesn't need to be consistently applied, tests not put in a folder will run the same way. The behavior that i would hope to be implemented in the blocking PR would allow for tests to appear in sub folders. As for the mass conflicts, I'm aware of the wave of them that will come, but I'm prepared to handle it, because I think this will really do some good |
Closing until blocking PR is merged, as the merge conflicts will only increase. |
This PR moves all of the
parallel/test-http-*
files intoparallel/http/test-*
. If this change goes well, I look to implement it throughout the entireparallel
folder (one subsystem at a time)IMO, the DX will be much easier with this change, as searching through tests will become simpler, as users can simply visit the
test/parallel/<subsystem>
directory.From a maintenance point of view, CODEOWNERS and label rules should be simpler, as a subdirectory now exists for these subsystems.
The
http
subsystem is largest subsystem (in number of test files), so I decided to handle it first.