tools: prepare custom rules for ESLint v9 #52889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Easier to review with https://github.com/nodejs/node/pull/52889/files?diff=unified&w=1 |
|
Fast-track has been requested by @targos. Please 👍 to approve. |
MoLow
approved these changes
May 8, 2024
lpinca
approved these changes
May 8, 2024
VoltrexKeyva
approved these changes
May 8, 2024
MoLow
added
the
author ready
|
/cc @aduh95 |
aduh95
approved these changes
May 9, 2024
anonrig
approved these changes
May 9, 2024
anonrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3c1069b |
targos
added a commit
that referenced
this pull request
May 11, 2024
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0 PR-URL: #52889 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
lukins-cz
pushed a commit
to lukins-cz/OS-Aplet-node
that referenced
this pull request
Jun 1, 2024
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0 PR-URL: nodejs#52889 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0