Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20.13.1 proposal #52900

Merged
merged 2 commits into from
May 9, 2024
Merged

v20.13.1 proposal #52900

merged 2 commits into from
May 9, 2024

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented May 8, 2024

2024-05-09, Version 20.13.1 'Iron' (LTS), @marco-ippolito

Revert "tools: install npm PowerShell scripts on Windows"

Due to a regression in the npm installation on Windows, this commit reverts the change that installed npm PowerShell scripts on Windows.

Commits

  • [b7d80802cc] - Revert "tools: install npm PowerShell scripts on Windows" (marco-ippolito) #52897

This reverts commit c39f15c.

PR-URL: #52897
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels May 8, 2024
marco-ippolito added a commit that referenced this pull request May 8, 2024
Notable changes:

tools:
  * Revert "tools: install npm PowerShell scripts on Windows" (Marco Ippolito) #52897

PR-URL: #52900
@marco-ippolito marco-ippolito removed the lib / src Issues and PRs related to general changes in the lib or src directory. label May 8, 2024
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2024
@nodejs-github-bot

This comment was marked as outdated.

Notable changes:

tools:
  * Revert "tools: install npm PowerShell scripts on Windows" (Marco Ippolito) #52897

PR-URL: #52900
@marco-ippolito
Copy link
Member Author

marco-ippolito commented May 8, 2024

updated with tomorrow's date since today I'll not make it due to CI flaky

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 8, 2024

marco-ippolito added a commit that referenced this pull request May 9, 2024
@marco-ippolito marco-ippolito merged commit b965ddd into v20.x May 9, 2024
54 checks passed
@marco-ippolito marco-ippolito deleted the v20.13.1-proposal branch May 9, 2024 10:28
marco-ippolito added a commit that referenced this pull request May 9, 2024
Notable changes:

tools:
  * Revert "tools: install npm PowerShell scripts on Windows" (Marco Ippolito) #52897

PR-URL: #52900
marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request May 9, 2024
marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request May 9, 2024
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request May 9, 2024
Blog: v20.13.1 release post

Refs: nodejs/node#52900
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
Notable changes:

tools:
  * Revert "tools: install npm PowerShell scripts on Windows" (Marco Ippolito) nodejs#52897

PR-URL: nodejs#52900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 20.13.0 for Windows users - NPM not installed with node
6 participants