Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x] Revert "tools: install npm PowerShell scripts on Windows" #52897

Closed
wants to merge 1 commit into from
Closed

[v20.x] Revert "tools: install npm PowerShell scripts on Windows" #52897

wants to merge 1 commit into from

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented May 8, 2024 •
edited
Loading

Reverts: #52009 on v20

@marco-ippolito marco-ippolito added the v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. label May 8, 2024
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels May 8, 2024
@marco-ippolito marco-ippolito changed the title Revert "tools: install npm PowerShell scripts on Windows" [v20.x] Revert "tools: install npm PowerShell scripts on Windows" May 8, 2024
@richardlau richardlau added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Fast-track has been requested by @richardlau. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59036/

marco-ippolito added a commit that referenced this pull request May 8, 2024
@marco-ippolito
Revert "tools: install npm PowerShell scripts on Windows"
b7d8080 
This reverts commit c39f15c.

PR-URL: #52897
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito added a commit that referenced this pull request May 8, 2024
@marco-ippolito
2024-05-08, Version 20.13.1 'Iron' (LTS)
7e5265d 
Notable changes:

tools:
  * Revert "tools: install npm PowerShell scripts on Windows" (Marco Ippolito) #52897

PR-URL: TODO
@marco-ippolito marco-ippolito mentioned this pull request May 8, 2024
Merged
marco-ippolito added a commit that referenced this pull request May 8, 2024
@marco-ippolito
2024-05-08, Version 20.13.1 'Iron' (LTS)
bd2263c 
Notable changes:

tools:
  * Revert "tools: install npm PowerShell scripts on Windows" (Marco Ippolito) #52897

PR-URL: #52900
@marco-ippolito
Copy link
Member Author

landed in b7d8080

marco-ippolito added a commit that referenced this pull request May 8, 2024
@marco-ippolito
2024-05-09, Version 20.13.1 'Iron' (LTS)
b965ddd 
Notable changes:

tools:
  * Revert "tools: install npm PowerShell scripts on Windows" (Marco Ippolito) #52897

PR-URL: #52900
marco-ippolito added a commit that referenced this pull request May 9, 2024
@marco-ippolito
2024-05-09, Version 20.13.1 'Iron' (LTS)
4338a28 
Notable changes:

tools:
  * Revert "tools: install npm PowerShell scripts on Windows" (Marco Ippolito) #52897

PR-URL: #52900
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@marco-ippolito @eliphazbouye
2024-05-09, Version 20.13.1 'Iron' (LTS)
eaae7e1 
Notable changes:

tools:
  * Revert "tools: install npm PowerShell scripts on Windows" (Marco Ippolito) nodejs#52897

PR-URL: nodejs#52900
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@marco-ippolito @bmeck
2024-05-09, Version 20.13.1 'Iron' (LTS)
9f84789 
Notable changes:

tools:
  * Revert "tools: install npm PowerShell scripts on Windows" (Marco Ippolito) nodejs#52897

PR-URL: nodejs#52900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marco-ippolito @nodejs-github-bot @lpinca @richardlau @RafaelGSS