Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.x] test: skip reproducible snapshot test on 32-bit #53592

Closed
wants to merge 1 commit into from
Closed

[v22.x] test: skip reproducible snapshot test on 32-bit #53592

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 26, 2024

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@targos targos requested a review from joyeecheung June 26, 2024 06:48
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jun 26, 2024
@targos targos changed the title test: skip reproducible snapshot test on 32-bit [v22.x] test: skip reproducible snapshot test on 32-bit Jun 26, 2024
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59971/

@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targos
Copy link
Member Author

targos commented Jun 26, 2024

Requesting fast-track to unblock #53583

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59972/

@marco-ippolito marco-ippolito added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Jun 26, 2024
targos added a commit that referenced this pull request Jun 26, 2024
@targos
test: skip reproducible snapshot test on 32-bit
1eebcbf 
Refs: #53583 (comment)
PR-URL: #53592
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targos
Copy link
Member Author

targos commented Jun 26, 2024

Landed in 1eebcbf

1 similar comment
@targos
Copy link
Member Author

targos commented Jun 26, 2024

Landed in 1eebcbf

@targos targos closed this Jun 26, 2024
@targos targos mentioned this pull request Jun 26, 2024
Merged
@Karliz24 Karliz24 mentioned this pull request Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@legendecas legendecas legendecas approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@targos @nodejs-github-bot @MoLow @legendecas @marco-ippolito