Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use Maybe<void> in node::crypto::error #53766

Merged
merged 1 commit into from
Jul 10, 2024
Merged

src: use Maybe<void> in node::crypto::error #53766

merged 1 commit into from
Jul 10, 2024

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Jul 8, 2024

With recent versions of V8, it is not necessary to use Maybe<bool> anymore.

@tniessen
src: use Maybe<void> in node::crypto::error
5f013f5 
With recent versions of V8, it is not necessary to use Maybe<bool>
anymore.
@tniessen tniessen added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 8, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jul 8, 2024
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60206/

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit a848206 into nodejs:main Jul 10, 2024
67 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a848206

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@tniessen @aduh95
src: use Maybe<void> in node::crypto::error
657288c 
With recent versions of V8, it is not necessary to use Maybe<bool>
anymore.

PR-URL: #53766
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tniessen @nodejs-github-bot @jasnell @anonrig @targos