-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: more explicit crypto.pseudoRandomBytes information #545
Conversation
Yes, but the reason may be invalid. When I added them, I reasoned that people may want to plug in a custom RAND engine but, to this day, I've never heard of anyone actually doing that. I speculate that people with hardware RNG devices feed that entropy into the system entropy pool, not directly into openssl. The PR LGTM but can you update the commit log? The first line should be <= 50 characters and there should be one or two lines describing the what and why of the change. Thanks! |
On the subject of crypto.pseudoRandomBytes(), your PR made me realize that there is probably no downside to making it an alias of crypto.randomBytes(). In the past, there was a material difference between them, but as of f68a116, that's no longer the case. |
Ok can amend the commit. Would it make sense to think about depreciating it? On Wed, Jan 21, 2015, 5:59 PM Ben Noordhuis notifications@github.com
|
Ok i can update the pull to do that as well On Wed, Jan 21, 2015, 6:03 PM Ben Noordhuis notifications@github.com
|
@calvinmetcalf Let's start with the documentation update. Changing crypto.pseudoRandomBytes() would also require ripping out some code from src/node_crypto.cc. |
Haha ok won't get ahead of myself On Wed, Jan 21, 2015, 6:07 PM Ben Noordhuis notifications@github.com
|
Updates the docs for the crypto.pseudoRandomBytes function to more explicitly detail how it's the same as crypto.randomBytes just without a safety net (e.g. it doesn't throw an error when there is low entropy).
83251c4
to
bfd2245
Compare
updated |
Updates the docs for the crypto.pseudoRandomBytes function to more explicitly detail how it's the same as crypto.randomBytes just without a safety net (e.g. it doesn't throw an error when there is low entropy). PR-URL: #545 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Thanks Calvin, landed in d481bb6 with minor touch-ups for line length. |
the docs as it is make it sound like pseudoRandomBytes is tapping a different entropy source or possibly might be a
/dev/urandom
tocrypto.pseudoRandomBytes
's/dev/random
.Is there a reason pseudoRandomBytes is in the api in the first place?