doc: move the readme newcomers section #6681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
force-pushed
the
readme-newcomers
branch
from
f934170
to
7b68418
Compare
|
great idea LGTM |
|
LGTM |
1 similar comment
|
LGTM |
Move the newcomers section to be more noticeable to those who it will be needed by. Also removed some entries that are now effectively duplicates. They are all in the above section. PR-URL: nodejs#6681 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Fishrock123
force-pushed
the
readme-newcomers
branch
from
7b68418
to
52b95f1
Compare
|
Thanks, landed in 52b95f1 |
|
Thanks, landed in 52b95f1 |
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
Move the newcomers section to be more noticeable to those who it will be needed by. Also removed some entries that are now effectively duplicates. They are all in the above section. PR-URL: #6681 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 2, 2016
Move the newcomers section to be more noticeable to those who it will be needed by. Also removed some entries that are now effectively duplicates. They are all in the above section. PR-URL: #6681 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 2, 2016
Move the newcomers section to be more noticeable to those who it will be needed by. Also removed some entries that are now effectively duplicates. They are all in the above section. PR-URL: #6681 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Move the newcomers section to be more noticeable to those who it will be needed by. Also removed some entries that are now effectively duplicates. They are all in the above section. PR-URL: #6681 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Move the newcomers section to be more noticeable to those who it will be needed by. Also removed some entries that are now effectively duplicates. They are all in the above section. PR-URL: #6681 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Move the newcomers section to be more noticeable to those who it will be needed by.
Also removed some entries that are now effectively duplicates. They are all in the above section.