v4.4.7 proposal #7395
Merged
v4.4.7 proposal #7395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct alignment on variable assignments that span multiple lines in preparation for lint rule to enforce such alignment. PR-URL: #6869 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Enforce alignment/indentation on variable assignments that span multiple lines. PR-URL: #6869 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
In debugger, the usage of `repl` very ugly. I'd like there is a `p`
like gdb. So the `exec` is coming.
Usage:
```
$ ./iojs debug ~/git/node_research/server.js
< Debugger listening on port 5858
connecting to 127.0.0.1:5858 ... ok
break in /Users/jacksontian/git/node_research/server.js:1
> 1 var http = require('http');
2
3 http.createServer(function (req, res) {
debug> exec process.title
/Users/jacksontian/git/io.js/out/Release/iojs
debug>
```
And the `repl`:
```
debug> repl
Press Ctrl + C to leave debug repl
> process.title
'/Users/jacksontian/git/io.js/out/Release/iojs'
debug>
(^C again to quit)
```
The enter and leave debug repl is superfluous.
R-URL: #1491
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Remove extra newlines that were causing rendering problems. PR-URL: #6958 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
`Object.prototype.__defineGetter__` is deprecated now, use `Object.defineProperty` instead. PR-URL: #6284 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. R=machenbach@chromium.org,jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{#31964} This adds some missing classes to postmortem info like JSMap and JSSet. PR-URL: #3792 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Set the mode bits on the history file to 0o600 instead of leaving it unspecified, which resulted in 0o755 on Unices. Test code mostly written by Trott: #3392 (comment). PR-URL: #3394 Fixes: #3392 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The Regex implementation is not faster than ascii code compare. the field name is shorter, the speed is faster. benchmark result here: https://bitbucket.org/snippets/JacksonTian/Rnbad/benchmark-result PR-URL: #4790 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #5986 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* Test the toHTML function in html.js. Check that given valid markdown it produces the expected html. One test case will prevent regressions of #5873. * Check that when given valid markdown toJSON produces valid JSON with the expected schema. * Add doctool to the list of built in tests so it runs in CI. PR-URL: #6031 Fixes: #5955 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rich Trott <rtrott@gmail.com>
`make binary` attempts to auto detect DESTCPU if not set, but was assuming being on an Intel architecture. PR-URL: #6310 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
added
the
meta
|
/cc @nodejs/lts |
PR-URL: #6194 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: #6224 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #6225 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #6226 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
These files are created by VS 2015 and should be ignored by git. PR-URL: #6070 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This is created by vs 2015 for user & machine-specific files and should be ignored by git. PR-URL: #6070 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* Modify tools/license-builder.sh to support ICU 57.1's plain text license. (Separate issue to add ICU 57.1 in #6058) * Update/regenerate LICENSE to include ICU 57.1's license * Note that because the tool was rerun, the change in #6065 is already included here. PR-URL: #6068 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #6257 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #6386 Reviewed-By: Johan Bergström <bugs@bergstroem.nu Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> PR-URL: #6385
PR-URL: #6389 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Also changed alias P.S.V.R to Minqi Pan. Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> PR-URL: #6387
|
lgtm |
|
@thealphanerd when will v4.5.0 with the updated async-wrap #7048 be released. I keep getting mails about it, and the only thing I can tell them is to be patient. |
|
@thealphanerd We should release this next week and move towards a speedy minor... We keep holding this stuff up really really long... |
|
The plan is to get this out ASAP as it includes fixes to a regression in
streams. We will then immediately turn around with a 4.5 rc which will
include the async wrap and minor changes. Considering a 3 week rc cycle.
Thoughts?
|
|
this all looks pretty vanilla, if citgm is happy then I'm happy, 👍 |
|
How about #7205 ? |
|
LGTM |
Replace '...' as invalid hostname with '***', which will give a more consisten error message on different systems. The hostname '...' returns EAI_AGAIN on musl libc and EAI_NONAME on most other systems. By changing the testcase we get same restult on all known platforms. PR-URL: #5099 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
The current layout is breaking the release post tool. This commit also removed erroneous entires in the main CHANGELOG for v4.4.6 and v5.12.0. PR-URL: #7394 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
force-pushed
the
v4.4.7-proposal
branch
from
e0ee375
to
f677d5f
Compare
|
@saghul We'll be testing the update to libuv for v4.5.0 |
|
let's try this again ci: https://ci.nodejs.org/job/node-test-pull-request/3100/ |
This commit backports a fix to a crankshaft bug affects arm64 systems.
Original commit message:
[arm64] Fix jssp based spill slot accesses in Crankshaft
Review URL: https://codereview.chromium.org/1401703003
Cr-Commit-Position: refs/heads/master@{#31304}
Fixes: #7417
PR-URL: #7442
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
force-pushed
the
v4.4.7-proposal
branch
from
f677d5f
to
313ecd9
Compare
|
/cc @nodejs/collaborators can ya'll please take a look at the changelog and ensure everything is A OK |
PR-URL: #7412 Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
force-pushed
the
v4.4.7-proposal
branch
2 times, most recently
from
867bcde
to
45e78fa
Compare
This LTS release comes with 89 commits. This includes 46 commits that
are docs related, 11 commits that are test related, 8 commits that are
build related, and 4 commits that are benchmark related.
Notable Changes:
- debugger:
- All properties of an array (aside from length) can now be printed
in the repl (cjihrig)
#6448
- npm:
- Upgrade npm to 2.15.8 (Rebecca Turner)
#7412
- stream:
- Fix for a bug that became more prevalent with the stream changes
that landed in v4.4.5. (Anna Henningsen)
#7160
- V8:
- Fix for a bug in crankshaft that was causing crashes on arm64
(Myles Borins)
#7442
- Add missing classes to postmortem info such as JSMap and JSSet
(evan.lucas)
#3792
MylesBorins
force-pushed
the
v4.4.7-proposal
branch
from
45e78fa
to
0974fc6
Compare
|
looks like what one would expect from a patch release on an LTS stream 👍 |
|
LGTM |
geminiyellow
added a commit
to ilivebox/heroku-nodejs
that referenced
this pull request
Jul 5, 2016
geminiyellow
added a commit
to ilivebox/heroku-nodejs
that referenced
this pull request
Jul 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2016-06-28, Version 4.4.7 'Argon' (LTS), @thealphanerd
This LTS release comes with 89 commits. This includes 46 commits that are docs related, 11 commits that are test related, 8 commits that are build related, and 4 commits that are benchmark related.
Notable Changes
Commits
87cdb83a96] - benchmark: merge url.js with url-resolve.js (Andreas Madsen) #5177921e8568d5] - benchmark: move misc to categorized directories (Andreas Madsen) #5177c189eec14e] - benchmark: fix configuation parameters (Andreas Madsen) #517758ad451f0b] - benchmark: move string-decoder to its own category (Andreas Madsen) #5177a01caa3166] - build: don't compile with -B, redux (Ben Noordhuis) #665037606caeaf] - build: don't compile with -B (Ben Noordhuis) #639364fb7a1929] - build: update android-configure script for npm (Robert Chiras) #634943ce6fc8d2] - build: fix DESTCPU detection for binary target (Richard Lau) #63106dfe7aeed5] - cares: Support malloc(0) scenarios for AIX (Gireesh Punathil) #63052389006720] - debugger: display array contents in repl (cjihrig) #64481c6809ce75] - debugger: introduce exec method for debugger (Jackson Tian)200b3ca9ed] - deps: upgrade npm in LTS to 2.15.8 (Rebecca Turner) #741249921e8819] - deps: backport 102e3e87e7 from V8 upstream (Myles Borins) #7442de00f91041] - deps: backport bc2e393 from v8 upstream (evan.lucas) #37921549899531] - dgram,test: add addMembership/dropMembership tests (Rich Trott) #67530ba3c2ca66] - doc: fix layout problem in v4 changelog (Myles Borins) #739498469ad84d] - doc: correct args for cluster message event (Colin Ihrig) #729767863f110b] - doc: update licenses (Myles Borins) #7127c31eaad42d] - doc: clarify buffer class (Steve Mao) #6914e0dd476fe5] - doc: fix typos in timers topic to aid readability (Kevin Donahue) #6916a8391bc9fc] - doc: add jhamhader to collaborators (Yuval Brik) #694622ca7b877b] - doc: add @othiym23 to list of collaborators (Forrest L Norvell) #69452c3c4e5819] - doc: reference list of language-specific globals (Anna Henningsen) #69005a1a0b5ed1] - doc: make the api doc print-friendly (Marian) #674803db88e012] - doc: add bengl to collaborators (Bryan English) #6921fbf95dde94] - doc: Update DCO to v1.1 (William Kapke) #6353f23a9c39c0] - doc: fix typo in Error.captureStackTrace (Mohsen) #681130ab6a890c] - doc: fix name to match git log (Robert Jefe Lindstaedt) #68802b0f40ca16] - doc: add note for fs.watch virtualized env (Robert Jefe Lindstaedt) #68093b461870be] - doc: Backport ee.once doc clarifications to 4.x. (Lance Ball) #7103eadb7e5b20] - doc: subdivide TOC, add auxiliary links (Jeremiah Senkpiel) #6167107839c5dd] - doc: no Node.js(1) (Jeremiah Senkpiel) #6167401325f9e2] - doc: better example & synopsis (Jeremiah Senkpiel) #6167c654184f28] - doc: remove link to Sign in crypto.md (Kirill Fomichev) #68123e9288e466] - doc: fix exec example in child_process (Evan Lucas) #66603d820e45b4] - doc: "a" -> "an" in api/documentation.md (Anchika Agarwal) #6689352496daa2] - doc: move the readme newcomers section (Jeremiah Senkpiel) #6681ac6b921ce5] - doc: mention existence/purpose of module wrapper (Matt Harrison) #643397d1fc0fc6] - doc: improve onboarding-extras.md formatting (Jeremiah Senkpiel) #6548c9b144ddd4] - doc: linkify remaining references to fs.Stats object (Kevin Donahue) #6485d909c25a33] - doc: fix the lint of an example in cluster.md (yorkie) #651621d02f460f] - doc: add missing underscore for markdown italics (Kevin Donahue) #652918ecc779bb] - doc: ensure consistent grammar in node.1 file (justshiv) #642652d9e7b61d] - doc: fix a typo in __dirname section (William Luo) #6473de20235235] - doc: remove all scrollbar styling (Claudio Rodriguez) #6479a6f45b4eda] - doc: Remove extra space in REPL example (Juan) #6447feda15b2b8] - doc: update build instructions for OS X (Rich Trott) #63093d1a3e4a30] - doc: change references to Stable to Current (Myles Borins) #6318e28598b1ef] - doc: update authors (James M Snell) #63730f3a94acbd] - doc: add JacksonTian to collaborators (Jackson Tian) #6388d7d54c8fd2] - doc: add Minqi Pan to collaborators (Minqi Pan) #638783721c6fd2] - doc: add eljefedelrodeodeljefe to collaborators (Robert Jefe Lindstaedt) #6389b112fd1b4e] - doc: add ronkorving to collaborators (ronkorving) #6385ac60d9cc86] - doc: add estliberitas to collaborators (Alexander Makarenko) #6386435cd56de5] - doc: DCO anchor that doesn't change (William Kapke) #62577d8141dd1b] - doc: add stefanmb to collaborators (Stefan Budeanu) #62276dfc96326d] - doc: add iWuzHere to collaborators (Imran Iqbal) #62263dbcc73159] - doc: add santigimeno to collaborators (Santiago Gimeno) #6225ae3eb24a3d] - doc: add addaleax to collaborators (Anna Henningsen) #622446ee7bb4ba] - doc: fix incorrect references in buffer docs (Amery) #6194e3f78eb7c1] - doc: improve rendering of v4.4.5 changelog entry (Myles Borins) #6958bac87d01d9] - gitignore: adding .vs/ directory to .gitignore (Mike Kaufman) #607093f2314dc2] - gitignore: ignore VS 2015 *.VC.opendb files (Mike Kaufman) #6070c98aaf59bf] - http: speed up checkIsHttpToken (Jackson Tian) #4790552e25cb6b] - lib,test: update in preparation for linter update (Rich Trott) #6498aaeeec4765] - lib,test,tools: alignment on variable assignments (Rich Trott) #6869b3acbc5648] - net: replace defineGetter with defineProperty (Fedor Indutny) #62844c1eb5bf03] - repl: create history file with mode 0600 (Carl Lei) #339490306bb81d] - src: use size_t for http parser array size fields (Ben Noordhuis) #5969af41a63d0f] - src: replace ARRAY_SIZE with typesafe arraysize (Ben Noordhuis) #5969037291e31f] - src: make sure Utf8Value always zero-terminates (Anna Henningsen) #7101a08a0179e9] - stream: ensure awaitDrain is increased once (David Halls) #7292b73ec46dcb] - stream: reset awaitDrain after manual .resume() (Anna Henningsen) #716055319fe798] - stream_base: exposebytesReadgetter (Fedor Indutny) #62840414d882ce] - test: fix test-net-* error code check for getaddrinfo(3) (Natanael Copa) #5099be0bb5f5fc] - test: fix unreliable known_issues test (Rich Trott) #6555ab50e82f42] - test: fix test-process-exec-argv flakiness (Santiago Gimeno) #71284e38655d5f] - test: refactor test-tls-reuse-host-from-socket (Rich Trott) #67561c4549a31e] - test: fix flaky test-stdout-close-catch (Santiago Gimeno) #68083b94e31245] - test: robust handling of env for npm-test-install (Myles Borins) #67974067cde7ee] - test: abstract skip functionality to common (Jeremiah Senkpiel) #71148b396e3d71] - test: fix test-debugger-repl-break-in-module (Rich Trott) #6686847b29c050] - test: fix test-debugger-repl-term (Rich Trott) #66821d68bdbe3f] - test: fix error message checks in test-module-loading (James M Snell) #59867e739ae159] - test,tools: adjust function argument alignment (Rich Trott) #7100216486c2b6] - tools: lint for function argument alignment (Rich Trott) #71006a76485ad7] - tools: update ESLint to 2.9.0 (Rich Trott) #6498a31153c02c] - tools: remove the minifying logic (Sakthipriyan Vairamani) #663610bd1a73fd] - tools: fix license-builder.sh again for ICU (Steven R. Loomis) #60680f6146c6c0] - tools: add tests for the doctool (Ian Kronquist) #6031cc3645cff3] - tools: lint for alignment of variable assignments (Rich Trott) #6869